From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752524AbeCNJ3f (ORCPT ); Wed, 14 Mar 2018 05:29:35 -0400 Received: from ozlabs.org ([103.22.144.67]:34009 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752377AbeCNJ2o (ORCPT ); Wed, 14 Mar 2018 05:28:44 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 1ff3b404019adf9d605224e1dce0677a0375d274 In-Reply-To: <20180304173132.19677-1-vaibhav@linux.vnet.ibm.com> To: Vaibhav Jain , Balbir Singh From: Michael Ellerman Cc: Vaibhav Jain , Frederic Barrat , linux-kernel@vger.kernel.org, Paul Mackerras , Nicholas Piggin , Douglas Miller , linuxppc-dev@lists.ozlabs.org Subject: Re: xmon: Clear all breakpoints when xmon is disabled via debugfs Message-Id: <401RHG6psmz9sVP@ozlabs.org> Date: Wed, 14 Mar 2018 20:28:33 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2018-03-04 at 17:31:32 UTC, Vaibhav Jain wrote: > Presently when xmon is disabled by debugfs any existing > instruction/data-access breakpoints set are not disabled. This may > lead to kernel oops when those breakpoints are hit as the necessary > debugger hooks aren't installed. > > Hence this patch introduces a new function named clear_all_bpt() > which is called when xmon is disabled via debugfs. The function will > unpatch/clear all the trap and ciabr/dab based breakpoints. > > Signed-off-by: Vaibhav Jain > Reviewed-by: Balbir Singh Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/1ff3b404019adf9d605224e1dce067 cheers