From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>,
Balbir Singh <bsingharora@gmail.com>
Cc: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>,
Frederic Barrat <fbarrat@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Nicholas Piggin <npiggin@gmail.com>,
Douglas Miller <dougmill@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [v2] xmon: Setup xmon debugger hooks when first break-point is set
Date: Wed, 14 Mar 2018 20:28:31 +1100 (AEDT) [thread overview]
Message-ID: <401RHQ2TS9z9s2R@ozlabs.org> (raw)
In-Reply-To: <20180304173025.19520-1-vaibhav@linux.vnet.ibm.com>
On Sun, 2018-03-04 at 17:30:25 UTC, Vaibhav Jain wrote:
> Presently sysrq key for xmon('x') is registered during kernel init
> irrespective of the value of kernel param 'xmon'. Thus xmon is enabled
> even if 'xmon=off' is passed on the kernel command line. However this
> doesn't enable the kernel debugger hooks needed for instruction or data
> breakpoints. Thus when a break-point is hit with xmon=off a kernel oops
> of the form below is reported:
>
> Oops: Exception in kernel mode, sig: 5 [#1]
> < snip >
> Trace/breakpoint trap
>
> To fix this the patch checks and enables debugger hooks when an
> instruction or data break-point is set via xmon console.
>
> Signed-off-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>
> Reviewed-by: Balbir Singh <bsingharora@gmail.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/e1368d0c9edbc366e45216e7295fd6
cheers
prev parent reply other threads:[~2018-03-14 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 17:30 [PATCH v2] xmon: Setup xmon debugger hooks when first break-point is set Vaibhav Jain
2018-03-04 21:29 ` Balbir Singh
2018-03-14 9:28 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=401RHQ2TS9z9s2R@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=bsingharora@gmail.com \
--cc=dougmill@linux.vnet.ibm.com \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=vaibhav@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox