From: Nick Piggin <piggin@cyberone.com.au>
To: Rick Lindsley <ricklind@us.ibm.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, mjbligh@us.ibm.com,
dvhltc@us.ibm.com
Subject: Re: [PATCH] Load balancing problem in 2.6.2-mm1
Date: Sat, 07 Feb 2004 08:57:56 +1100 [thread overview]
Message-ID: <40240DE4.8030705@cyberone.com.au> (raw)
In-Reply-To: <200402061813.i16IDO707026@owlet.beaverton.ibm.com>
Rick Lindsley wrote:
> >+ if ((long)*imbalance < 0)
> >+ *imbalance = 0;
> >
>
> You're right Rick, thanks for catching this. Why do you have
> this last test though? This shouldn't be possible?
>
>A combination of paranoia and leftover code from a previous fix :) At the
>least, this could probably become a BUG_ON now, or I wouldn't cry if
>we took it out entirely.
>
>
I gave it a run with WARN_ON for a while and its fine so we'll
take it out all together.
We also shouldn't need load_diff, because if (avg_load <= this_load)
then imbalance will be zero, so I'll fix that up.
next prev parent reply other threads:[~2004-02-06 21:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-06 9:24 [PATCH] Load balancing problem in 2.6.2-mm1 Rick Lindsley
2004-02-06 9:38 ` Nick Piggin
2004-02-06 18:13 ` Rick Lindsley
2004-02-06 21:57 ` Nick Piggin [this message]
2004-02-06 22:30 ` Rick Lindsley
2004-02-06 22:40 ` Nick Piggin
2004-02-06 22:49 ` Rick Lindsley
2004-02-06 23:08 ` Nick Piggin
2004-02-06 10:30 ` Anton Blanchard
2004-02-06 18:15 ` Rick Lindsley
2004-02-06 18:39 ` Martin J. Bligh
2004-02-06 22:02 ` Nick Piggin
2004-02-06 22:34 ` Rick Lindsley
2004-02-06 22:48 ` Nick Piggin
2004-02-06 22:42 ` Martin J. Bligh
2004-02-06 22:53 ` Nick Piggin
2004-02-06 23:11 ` Rick Lindsley
2004-02-06 23:20 ` Nick Piggin
2004-02-06 23:33 ` Martin J. Bligh
2004-02-06 23:41 ` Nick Piggin
2004-02-06 23:47 ` Martin J. Bligh
2004-02-07 0:11 ` Nick Piggin
2004-02-07 0:25 ` Martin J. Bligh
2004-02-07 0:31 ` Nick Piggin
2004-02-07 9:50 ` Anton Blanchard
2004-02-08 0:40 ` Rick Lindsley
2004-02-08 1:12 ` Anton Blanchard
2004-02-08 1:21 ` Nick Piggin
2004-02-08 1:41 ` Anton Blanchard
2004-02-08 3:20 ` Nick Piggin
2004-02-08 3:57 ` Anton Blanchard
2004-02-08 4:05 ` Nick Piggin
2004-02-08 12:14 ` Anton Blanchard
2004-02-08 1:22 ` Anton Blanchard
2004-02-09 16:37 ` Timothy Miller
2004-02-09 16:43 ` Martin J. Bligh
2004-02-06 18:33 ` Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40240DE4.8030705@cyberone.com.au \
--to=piggin@cyberone.com.au \
--cc=akpm@osdl.org \
--cc=dvhltc@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjbligh@us.ibm.com \
--cc=ricklind@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox