Re: [PATCH] Load balancing problem in 2.6.2-mm1

Nick Piggin
2004-02-06T21:58:55Z

Rick Lindsley wrote:

> >+ if ((long)*imbalance < 0)
> >+ *imbalance = 0;
> >
>
> You're right Rick, thanks for catching this. Why do you have
> this last test though? This shouldn't be possible?
>
>A combination of paranoia and leftover code from a previous fix :) At the
>least, this could probably become a BUG_ON now, or I wouldn't cry if
>we took it out entirely.
>
>

I gave it a run with WARN_ON for a while and its fine so we'll
take it out all together.

We also shouldn't need load_diff, because if (avg_load <= this_load)
then imbalance will be zero, so I'll fix that up.