public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Luis Miguel García" <ktech@wanadoo.es>
To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Cc: Andrew Morton <akpm@osdl.org>,
	david+challenge-response@blue-labs.org,
	acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	a.verweij@student.tudelft.nl
Subject: Re: [ACPI] acpi problem with nforce motherboards and ethernet
Date: Sat, 07 Feb 2004 07:29:20 +0100	[thread overview]
Message-ID: <402485C0.905@wanadoo.es> (raw)
In-Reply-To: <Pine.LNX.4.55.0402070021210.12260@jurand.ds.pg.gda.pl>

Maciej W. Rozycki wrote:

>On Thu, 5 Feb 2004, Andrew Morton wrote:
>
>  
>
>>>By the way, is anyone involved in solving the IO-APIC thing in nforce 
>>>motherboards? Anyone trying a different approach? Anyone contacting 
>>>nvidia about this problem?
>>>      
>>>
>>As far as I know, we're dead in the water on these problems.
>>    
>>
>
> Not necessarily. :-)
>
>  
>
>>Here's one:
>>
>>
>>[x86] do not wrongly override mp_ExtINT IRQ
>>
>>From: Mathieu <cheuche+lkml@free.fr>.
>>
>>With this patch timer IRQ0 is correctly set to IO-APIC-edge
>>(not XT-PIC) on nForce2 boards when using APIC and ACPI.
>>
>> arch/i386/kernel/mpparse.c |    3 ++-
>> 1 files changed, 2 insertions(+), 1 deletion(-)
>>
>>diff -puN arch/i386/kernel/mpparse.c~nforce2-apic arch/i386/kernel/mpparse.c
>>--- linux-2.6.0-test11/arch/i386/kernel/mpparse.c~nforce2-apic	2003-12-08 00:12:25.782597272 +0100
>>+++ linux-2.6.0-test11-root/arch/i386/kernel/mpparse.c	2003-12-08 00:12:25.786596664 +0100
>>@@ -962,7 +962,8 @@ void __init mp_override_legacy_irq (
>> 	 */
>> 	for (i = 0; i < mp_irq_entries; i++) {
>> 		if ((mp_irqs[i].mpc_dstapic == intsrc.mpc_dstapic) 
>>-			&& (mp_irqs[i].mpc_srcbusirq == intsrc.mpc_srcbusirq)) {
>>+			&& (mp_irqs[i].mpc_srcbusirq == intsrc.mpc_srcbusirq)
>>+			&& (mp_irqs[i].mpc_irqtype == intsrc.mpc_irqtype)) {
>> 			mp_irqs[i] = intsrc;
>> 			found = 1;
>> 			break;
>>    
>>
>
> That's not the right fix.  There's a bug in Linux's ACPI IRQ setup as
>I've discovered by comparing the code to the spec.  Here's a patch I sent
>in December both to the LKML and the ACPI maintainer.  The feedback from
>the list was positive, but the maintainer didn't bother to comment.
>
> I haven't pushed the patch more firmly, because the MIPS port is my
>priority and I don't even have any ACPI-aware equipment.
>
> Maciej
>
>  
>
Can you send us the specific patch or at least telling us if you're 
going to push it?

Thanks a lot for the fix ;)

LuisMi Garcia

  parent reply	other threads:[~2004-02-07  6:29 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-05 19:25 [ACPI] acpi problem with nforce motherboards and ethernet Luis Miguel García
2004-02-05 19:44 ` David Ford
2004-02-05 21:27   ` Luis Miguel García
2004-02-05 23:40     ` Andrew Morton
2004-02-06  0:08       ` Prakash K. Cheemplavam
2004-02-06  0:14       ` Craig Bradney
2004-02-06  0:22         ` Luis Miguel García
2004-02-06  0:38           ` Prakash K. Cheemplavam
2004-02-06  0:46             ` Luis Miguel García
2004-02-06  0:58               ` Prakash K. Cheemplavam
2004-02-06  1:01                 ` Craig Bradney
2004-02-06  1:09                   ` Luis Miguel García
2004-02-06  9:28                     ` Prakash K. Cheemplavam
2004-02-06  9:26                   ` Prakash K. Cheemplavam
2004-02-06 10:07                     ` Craig Bradney
2004-02-06 10:40                       ` Prakash K. Cheemplavam
2004-02-06  9:44                         ` Daniel Drake
2004-02-06 11:04                           ` Prakash K. Cheemplavam
2004-02-06 11:15                             ` Prakash K. Cheemplavam
2004-02-06 12:51                               ` Craig Bradney
2004-02-06 13:10                                 ` Arjen Verweij
2004-02-06 13:20                                 ` Prakash K. Cheemplavam
2004-02-06 13:34                                 ` Arjen Verweij
2004-02-06 13:41                                   ` Prakash K. Cheemplavam
2004-02-06 13:43                                   ` Prakash K. Cheemplavam
2004-02-06 11:08                       ` Craig Bradney
2004-02-06  0:59               ` Craig Bradney
2004-02-06  0:56           ` Craig Bradney
2004-02-06 23:33       ` Maciej W. Rozycki
2004-02-07  2:50         ` Andi Kleen
2004-02-07  6:39           ` Josh McKinney
2004-02-07 10:04             ` Maciej W. Rozycki
2004-02-07  6:29         ` Luis Miguel García [this message]
2004-02-06  9:47     ` Daniel Drake
  -- strict thread matches above, loose matches on Subject: below --
2004-02-05 17:41 Luis Miguel García
2004-02-05 18:41 ` [ACPI] " Arjen Verweij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=402485C0.905@wanadoo.es \
    --to=ktech@wanadoo.es \
    --cc=a.verweij@student.tudelft.nl \
    --cc=acpi-devel@lists.sourceforge.net \
    --cc=akpm@osdl.org \
    --cc=david+challenge-response@blue-labs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@ds2.pg.gda.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox