From: walt <wa1ter@myrealbox.com>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Re: [2.6.1] Kernel panic with ppa driver updates
Date: Sat, 07 Feb 2004 21:06:56 -0800 [thread overview]
Message-ID: <4025C3F0.7000804@myrealbox.com> (raw)
In-Reply-To: <fa.n3claqs.1ihaob0@ifi.uio.no>
viro@parcelfarce.linux.theplanet.co.uk wrote:
> On Sat, Feb 07, 2004 at 07:35:52PM -0800, walt wrote:
>>ppa: Version 2.07 (for Linux 2.4.x)
>>dev = dfd67940, dev->cur_cmd = 7232b2df
>>Unable to handle kernel paging request at virtual address 7232b403
> Aaaaaargh.... memset(dev, 0, sizeof(dev)); - spot the bug here...
>
> Fix follows. Linus, apply it, please. Amazing that it survives in modular
> case...
>
> diff -urN RC2-bk1-base/drivers/scsi/imm.c RC2-bk1-current/drivers/scsi/imm.c
> --- RC2-bk1-base/drivers/scsi/imm.c Thu Feb 5 18:48:49 2004
> +++ RC2-bk1-current/drivers/scsi/imm.c Sat Feb 7 22:44:16 2004
> @@ -1153,7 +1153,7 @@
> if (!dev)
> return -ENOMEM;
>
> - memset(dev, 0, sizeof(dev));
> + memset(dev, 0, sizeof(imm_struct));
>
> dev->base = -1;
> dev->mode = IMM_AUTODETECT;
> diff -urN RC2-bk1-base/drivers/scsi/ppa.c RC2-bk1-current/drivers/scsi/ppa.c
> --- RC2-bk1-base/drivers/scsi/ppa.c Thu Feb 5 18:48:57 2004
> +++ RC2-bk1-current/drivers/scsi/ppa.c Sat Feb 7 22:44:27 2004
> @@ -1010,7 +1010,7 @@
> dev = kmalloc(sizeof(ppa_struct), GFP_KERNEL);
> if (!dev)
> return -ENOMEM;
> - memset(dev, 0, sizeof(dev));
> + memset(dev, 0, sizeof(ppa_struct));
> dev->base = -1;
> dev->mode = PPA_AUTODETECT;
> dev->recon_tmo = PPA_RECON_TMO;
> -
Yes, it's fixed now. Thank you!
next parent reply other threads:[~2004-02-08 5:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.fsggm3p.17jmtpp@ifi.uio.no>
[not found] ` <fa.n3claqs.1ihaob0@ifi.uio.no>
2004-02-08 5:06 ` walt [this message]
[not found] <fa.db71fu4.1gju7jo@ifi.uio.no>
[not found] ` <fa.n1cha2m.1hhep3a@ifi.uio.no>
2004-02-08 3:35 ` [2.6.1] Kernel panic with ppa driver updates walt
2004-02-08 3:48 ` [PATCH] " viro
2004-02-08 3:50 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4025C3F0.7000804@myrealbox.com \
--to=wa1ter@myrealbox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox