* [PATCH] Minor cross-compile issues
@ 2004-02-09 16:39 Pratik Solanki
2004-02-16 20:58 ` Sam Ravnborg
0 siblings, 1 reply; 5+ messages in thread
From: Pratik Solanki @ 2004-02-09 16:39 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linux Kernel
[-- Attachment #1: Type: text/plain, Size: 250 bytes --]
Attached are 2 patches
asm-boot.patch - Fixes include path for build.c so that it finds
asm/boot.h. /usr/include/asm/boot.h may not be present when
cross-compiling on a non-Linux machine.
shell.patch - Use $(CONFIG_SHELL) instead of sh.
Pratik.
[-- Attachment #2: asm-boot.patch --]
[-- Type: text/plain, Size: 384 bytes --]
===== arch/i386/boot/Makefile 1.28 vs edited =====
--- 1.28/arch/i386/boot/Makefile Thu Sep 11 06:01:23 2003
+++ edited/arch/i386/boot/Makefile Thu Feb 5 15:56:28 2004
@@ -31,6 +31,8 @@
host-progs := tools/build
+HOSTCFLAGS_build.o := -I$(TOPDIR)/include
+
# ---------------------------------------------------------------------------
$(obj)/zImage: IMAGE_OFFSET := 0x1000
[-- Attachment #3: shell.patch --]
[-- Type: text/plain, Size: 409 bytes --]
===== init/Makefile 1.26 vs edited =====
--- 1.26/init/Makefile Sat Apr 26 14:43:03 2003
+++ edited/init/Makefile Thu Feb 5 15:43:29 2004
@@ -23,4 +23,4 @@
include/linux/compile.h: FORCE
@echo ' CHK $@'
- @sh $(srctree)/scripts/mkcompile_h $@ "$(UTS_MACHINE)" "$(CONFIG_SMP)" "$(CC) $(CFLAGS)"
+ @$(CONFIG_SHELL) $(srctree)/scripts/mkcompile_h $@ "$(UTS_MACHINE)" "$(CONFIG_SMP)" "$(CC) $(CFLAGS)"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Minor cross-compile issues
2004-02-09 16:39 [PATCH] Minor cross-compile issues Pratik Solanki
@ 2004-02-16 20:58 ` Sam Ravnborg
2004-02-17 16:35 ` Pratik Solanki
0 siblings, 1 reply; 5+ messages in thread
From: Sam Ravnborg @ 2004-02-16 20:58 UTC (permalink / raw)
To: Pratik Solanki; +Cc: Andrew Morton, Linux Kernel
On Mon, Feb 09, 2004 at 11:39:47AM -0500, Pratik Solanki wrote:
> Attached are 2 patches
>
> asm-boot.patch - Fixes include path for build.c so that it finds
> asm/boot.h. /usr/include/asm/boot.h may not be present when
> cross-compiling on a non-Linux machine.
OK - but see minor comemnt.
> shell.patch - Use $(CONFIG_SHELL) instead of sh.
OK
Sam
> ===== arch/i386/boot/Makefile 1.28 vs edited =====
> --- 1.28/arch/i386/boot/Makefile Thu Sep 11 06:01:23 2003
> +++ edited/arch/i386/boot/Makefile Thu Feb 5 15:56:28 2004
> @@ -31,6 +31,8 @@
>
> host-progs := tools/build
>
> +HOSTCFLAGS_build.o := -I$(TOPDIR)/include
Do not use absolute paths here.
> +HOSTCFLAGS_build.o := -Iinclude
Is the preferred way to do it.
Sam
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Minor cross-compile issues
2004-02-16 20:58 ` Sam Ravnborg
@ 2004-02-17 16:35 ` Pratik Solanki
2004-02-17 17:00 ` Sam Ravnborg
0 siblings, 1 reply; 5+ messages in thread
From: Pratik Solanki @ 2004-02-17 16:35 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Andrew Morton, Linux Kernel
On 02/16/2004 03:58 PM, Sam Ravnborg wrote:
>On Mon, Feb 09, 2004 at 11:39:47AM -0500, Pratik Solanki wrote:
>
>
>>Attached are 2 patches
>>
>>asm-boot.patch - Fixes include path for build.c so that it finds
>>asm/boot.h. /usr/include/asm/boot.h may not be present when
>>cross-compiling on a non-Linux machine.
>>
>>
>OK - but see minor comemnt.
>
>
>
>
>>shell.patch - Use $(CONFIG_SHELL) instead of sh.
>>
>>
>OK
>
> Sam
>
>
>
>>===== arch/i386/boot/Makefile 1.28 vs edited =====
>>--- 1.28/arch/i386/boot/Makefile Thu Sep 11 06:01:23 2003
>>+++ edited/arch/i386/boot/Makefile Thu Feb 5 15:56:28 2004
>>@@ -31,6 +31,8 @@
>>
>> host-progs := tools/build
>>
>>+HOSTCFLAGS_build.o := -I$(TOPDIR)/include
>>
>>
>Do not use absolute paths here.
>
>
>
>>+HOSTCFLAGS_build.o := -Iinclude
>>
>>
>Is the preferred way to do it.
>
>
Thanks Sam. Would you be checking in your proposed change or should I
send a new patch?
Pratik.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Minor cross-compile issues
2004-02-17 16:35 ` Pratik Solanki
@ 2004-02-17 17:00 ` Sam Ravnborg
2004-02-17 17:29 ` Pratik Solanki
0 siblings, 1 reply; 5+ messages in thread
From: Sam Ravnborg @ 2004-02-17 17:00 UTC (permalink / raw)
To: Pratik Solanki; +Cc: Sam Ravnborg, Andrew Morton, Linux Kernel
On Tue, Feb 17, 2004 at 11:35:43AM -0500, Pratik Solanki wrote:
>
> Thanks Sam. Would you be checking in your proposed change or should I
> send a new patch?
Please send an updated patch to Andrew Morton.
Sam
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Minor cross-compile issues
2004-02-17 17:00 ` Sam Ravnborg
@ 2004-02-17 17:29 ` Pratik Solanki
0 siblings, 0 replies; 5+ messages in thread
From: Pratik Solanki @ 2004-02-17 17:29 UTC (permalink / raw)
To: Andrew Morton; +Cc: Sam Ravnborg, Linux Kernel
[-- Attachment #1: Type: text/plain, Size: 355 bytes --]
Andrew,
Based on Sam's suggestion, here's the updated patch.
Pratik.
On 02/17/2004 12:00 PM, Sam Ravnborg wrote:
>On Tue, Feb 17, 2004 at 11:35:43AM -0500, Pratik Solanki wrote:
>
>
>>Thanks Sam. Would you be checking in your proposed change or should I
>>send a new patch?
>>
>>
>
>Please send an updated patch to Andrew Morton.
>
> Sam
>
>
[-- Attachment #2: asm-boot.patch --]
[-- Type: text/plain, Size: 374 bytes --]
===== arch/i386/boot/Makefile 1.28 vs edited =====
--- 1.28/arch/i386/boot/Makefile Thu Sep 11 06:01:23 2003
+++ edited/arch/i386/boot/Makefile Tue Feb 17 11:56:45 2004
@@ -31,6 +31,8 @@
host-progs := tools/build
+HOSTCFLAGS_build.o := -Iinclude
+
# ---------------------------------------------------------------------------
$(obj)/zImage: IMAGE_OFFSET := 0x1000
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2004-02-17 17:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-02-09 16:39 [PATCH] Minor cross-compile issues Pratik Solanki
2004-02-16 20:58 ` Sam Ravnborg
2004-02-17 16:35 ` Pratik Solanki
2004-02-17 17:00 ` Sam Ravnborg
2004-02-17 17:29 ` Pratik Solanki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox