From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753935AbbJPMEi (ORCPT ); Fri, 16 Oct 2015 08:04:38 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:61082 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772AbbJPMEh (ORCPT ); Fri, 16 Oct 2015 08:04:37 -0400 From: Arnd Bergmann To: Hannes Reinecke Cc: linux-arm-kernel@lists.infradead.org, linux-scsi@vger.kernel.org, JBottomley@odin.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: advansys needs ISA dma api for ISA support Date: Fri, 16 Oct 2015 14:04:31 +0200 Message-ID: <40283310.IhmmM0l1HG@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <5620E432.1000709@suse.de> References: <5081546.QjQ32dGX2L@wuerfel> <8749889.aUxSEGWaCq@wuerfel> <5620E432.1000709@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:eEhLZFPQjIOt1g5MBhUZCtz3b/nKdjDBKkj0RR8mDds3hOPx0IP cBFJj5JiDNjQPqGA0mqWzaa4BIBuJ1XjA2iroBg0w9Ebpf0xlsSOe7eSieIOtAEhAi/8rpg lNacj5p+fN4Zp8OSrmGgvsknhbkU9zd9TNqwNs4a4GHD14HxlQ5JpP43EQr3CO1oy4v/Zed LtAK1yTOCxzQCd7VoKF7g== X-UI-Out-Filterresults: notjunk:1;V01:K0:bI4e+F/1O00=:FATClrtNB3zjtKB1L4HiKo AOllCl/iabDTqfnUwskRhWL7omMD3hBNvQIGNLGLSaBPSipYrK4bayAbE0vbOVMVo7bx55+SS DSbuKWG6/AltfQnAFtjc0NcHyxIOq+HwTldeJvEl6KshNco8pe7xvYp7xG2//VEywg0qql/75 kGLIA1DwRZVahTP3DJUbroOzfybf1Xl33Wv0Os/EOoYgOejfjORlGnRnxGvBIgN10hhD1SwYs osuq+97XruHKZ583Wcg/jdFIA5EEfCptWVVHtOIXPxLbc4u2ok0gO4uPAHujsV+1UoZU/owH5 mdQSEsNpt5uXDLS/f4QLtF9zyk/KD2HiZg1jsw98PPg5s4SVzoffH1fNlcf6iTs/jzxKwT1f8 atUMrVYCdF+JMF+Dn+bsN0KuOl4Qs7QXaWE3EhsT9MqkLvQfH1JnF4zPQOgGpA2OeL7ZrfZCo rPynkwsqEuCbdtX/qA2qomtWmNa5CCxqPLHciOJBa1o5Y891/ykt7gKqgFOnccIo53PjH07jS HWLbkQeQzCOnP0g38+iGn8ta2whQB0QxoeElpd8oDso//aDYdAZnufvLYMSbw4RWYw/0V9aT9 HXKCgJyrjmVmJbTd/mNGb0nn1wE6UTsNT3jZ/lR/3hvnbWxLqQw5N8HGZNQ8m2uxIlk5hxieH RmeSqmZI1LIbdMKgGu8LYxBh64NPUdWqbE+Tf5vgwFzpB98+PWSVDyGm6Wxet0nM/A9eFcC1J M5vKS0lso6FbXOas Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 16 October 2015 13:49:06 Hannes Reinecke wrote: > On 10/15/2015 05:04 PM, Arnd Bergmann wrote: > > On Thursday 15 October 2015 14:09:31 Hannes Reinecke wrote: > >> On 10/15/2015 02:06 PM, Hannes Reinecke wrote: > >>> On 10/12/2015 05:10 PM, Arnd Bergmann wrote: > >>>> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > >>>> index d2f480b04a52..d4aa6a1a806c 100644 > >>>> --- a/drivers/scsi/Kconfig > >>>> +++ b/drivers/scsi/Kconfig > >>>> @@ -499,6 +499,7 @@ config SCSI_ADVANSYS > >>>> tristate "AdvanSys SCSI support" > >>>> depends on SCSI > >>>> depends on ISA || EISA || PCI > >>>> + depends on ISA_DMA_API || !ISA > >>>> help > >>>> This is a driver for all SCSI host adapters manufactured by > >>>> AdvanSys. It is documented in the kernel source in > >>>> > >>> Sorry to chime in again, but wouldn't this allow to build on platforms > >>> which have neither ISA_DMA_API nor ISA, like oldish sparc systems with > >>> proprietary S-BUS? > > > > No, the first dependency is still in place. It could also be written as > > > > depends on (ISA && ISA_DMA_API) || EISA || PCI > > > > which might be easier to understand. Do you want me to resubmit it like that? > > > Yes, please do so. > I now realized that they are not the same: the new version allows building on systems with PCI and ISA but no ISA_DMA_API, which the driver should be able to handle but doesn't (unless my second patch is applied). However, I don't think that this combination exists, so we should still be good, and it does express what the hardware can do. I'll send it after my build regression tests are complete. Arnd