public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Pankratov <ap@swapped.cc>
To: Andi Kleen <ak@suse.de>
Cc: acme@conectiva.com.br, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [2.6] [1/2] hlist: replace explicit checks of hlist fields w/ func calls
Date: Wed, 11 Feb 2004 20:52:39 -0800	[thread overview]
Message-ID: <402B0697.7010109@swapped.cc> (raw)
In-Reply-To: <20040214012805.52e4af60.ak@suse.de>



Andi Kleen wrote:

> On Tue, 10 Feb 2004 22:57:43 -0800
> Alex Pankratov <ap@swapped.cc> wrote:
> 
> 
>>Ugh, yeah, I thought about this. However my understand was that
>>since hlist_null is statically allocated variable, its address
>>will be a known constant at a link time (whether it's a static
>>link or dynamic/run-time link - btw, excuse my lack of proper
>>terminology here). So comparing something to &null would be
>>equivalent to comparing to the constant and not require an
>>extra register.
> 
> 
> Hmm, you're right. Apparently I was still thinking about the bad
> code generated by the standard list_heads. 
> 

A quick note about standard lists then - circular double-linked
lists are normally described in textbooks as a clever trick
allowing to avoid if's in insert() and delete(). Given what you
have noted about CMP speed above, I wonder if simple 0-terminated
lists would be something to consider for lower-end i386.

Alex


  parent reply	other threads:[~2004-02-12  4:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-11  6:28 [PATCH] [2.6] [1/2] hlist: replace explicit checks of hlist fields w/ func calls Alex Pankratov
2004-02-13 22:14 ` Andi Kleen
2004-02-11  6:57   ` Alex Pankratov
2004-02-11 12:10     ` Arnaldo Carvalho de Melo
2004-02-14  0:28     ` Andi Kleen
2004-02-11 16:37       ` Alex Pankratov
2004-02-12  4:52       ` Alex Pankratov [this message]
2004-02-12  8:43         ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=402B0697.7010109@swapped.cc \
    --to=ap@swapped.cc \
    --cc=acme@conectiva.com.br \
    --cc=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox