From: Coywolf Qi Hunt <coywolf@lovecn.org>
To: Riley@Williams.Name, davej@suse.de, hpa@zytor.com
Cc: Linux-Kernel@vger.kernel.org
Subject: [PATCH 2.4.24] Fix GDT limit in setup.S
Date: Tue, 17 Feb 2004 03:07:05 +0800 [thread overview]
Message-ID: <403114D9.2060402@lovecn.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
Hello 2.4.xx hackers,
In setup.S, i feel like that the gdt limit 0x8000 is not proper and it
should be 0x800. How came 0x800 into 0x8000 in 2.4.xx code? Is there a
story? It shouldn't be a careless typo. 256 gdt entries should be
enough and since it's boot gdt, 256 is ok even if the code is run on SMP
with 64 cpus.
At least the comment doesn't match the code. Either fix the code or fix
the comment. We really needn't so many GDT entries. Let's use the intel
segmentation in a most limited way. Below follows a patch fixing the code.
I don't have the latest 2.4.24, but setup.S isn't changed from 2.4.23 to
2.4.24.
Regards, Coywolf
--
Coywolf Qi Hunt
Admin of http://GreatCN.org and http://LoveCN.org
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 368 bytes --]
--- arch/i386/boot/setup.S.orig 2003-11-29 02:26:20.000000000 +0800
+++ arch/i386/boot/setup.S 2004-02-17 01:15:42.000000000 +0800
@@ -1093,7 +1093,7 @@
.word 0 # idt limit = 0
.word 0, 0 # idt base = 0L
gdt_48:
- .word 0x8000 # gdt limit=2048,
+ .word 0x800 # gdt limit=2048,
# 256 GDT entries
.word 0, 0 # gdt base (filled in later)
next reply other threads:[~2004-02-16 19:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-16 19:07 Coywolf Qi Hunt [this message]
2004-02-16 20:44 ` [PATCH 2.4.24] Fix GDT limit in setup.S Richard B. Johnson
2004-02-19 0:54 ` Coywolf Qi Hunt
2004-02-19 1:18 ` Coywolf Qi Hunt
2004-02-19 8:33 ` { Linux not only practical, but an ideal. } " Coywolf Qi Hunt
2004-02-17 3:51 ` [2.0.40 2.2.25 2.4.25] Fix boot GDT limit 0x800 to 0x7ff in setup.S or not Coywolf Qi Hunt
2004-02-21 3:39 ` Coywolf Qi Hunt
2004-02-21 4:12 ` H. Peter Anvin
2004-02-23 5:30 ` Coywolf Qi Hunt
2004-02-23 14:02 ` [PATCH] Fix GDT limit in setup.S for 2.0 and 2.2 Coywolf Qi Hunt
2004-02-23 14:21 ` David Weinehall
2004-02-25 0:10 ` Pavel Machek
2004-02-23 14:43 ` Richard B. Johnson
2004-02-23 15:28 ` Richard B. Johnson
2004-02-23 16:21 ` Richard B. Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=403114D9.2060402@lovecn.org \
--to=coywolf@lovecn.org \
--cc=Linux-Kernel@vger.kernel.org \
--cc=Riley@Williams.Name \
--cc=davej@suse.de \
--cc=hpa@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox