public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pratik Solanki <pratik.solanki@timesys.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Minor cross-compile issues
Date: Tue, 17 Feb 2004 11:35:43 -0500	[thread overview]
Message-ID: <403242DF.7030204@timesys.com> (raw)
In-Reply-To: <20040216205800.GC2977@mars.ravnborg.org>

On 02/16/2004 03:58 PM, Sam Ravnborg wrote:

>On Mon, Feb 09, 2004 at 11:39:47AM -0500, Pratik Solanki wrote:
>  
>
>>Attached are 2 patches
>>
>>asm-boot.patch - Fixes include path for build.c so that it finds 
>>asm/boot.h. /usr/include/asm/boot.h may not be present when 
>>cross-compiling on a non-Linux machine.
>>    
>>
>OK - but see minor comemnt.
>
> 
>  
>
>>shell.patch - Use $(CONFIG_SHELL) instead of sh.
>>    
>>
>OK
>
>	Sam
>
>  
>
>>===== arch/i386/boot/Makefile 1.28 vs edited =====
>>--- 1.28/arch/i386/boot/Makefile	Thu Sep 11 06:01:23 2003
>>+++ edited/arch/i386/boot/Makefile	Thu Feb  5 15:56:28 2004
>>@@ -31,6 +31,8 @@
>> 
>> host-progs	:= tools/build
>> 
>>+HOSTCFLAGS_build.o := -I$(TOPDIR)/include
>>    
>>
>Do not use absolute paths here.
>
>  
>
>>+HOSTCFLAGS_build.o := -Iinclude
>>    
>>
>Is the preferred way to do it.
>  
>

Thanks Sam. Would you be checking in your proposed change or should I 
send a new patch?

Pratik.

  reply	other threads:[~2004-02-17 16:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-09 16:39 [PATCH] Minor cross-compile issues Pratik Solanki
2004-02-16 20:58 ` Sam Ravnborg
2004-02-17 16:35   ` Pratik Solanki [this message]
2004-02-17 17:00     ` Sam Ravnborg
2004-02-17 17:29       ` Pratik Solanki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=403242DF.7030204@timesys.com \
    --to=pratik.solanki@timesys.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox