From: Jim Paradis <jparadis@redhat.com>
To: torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Fix fencepost error in x86_64 IOMMU (2.6)
Date: Tue, 17 Feb 2004 16:18:40 -0500 [thread overview]
Message-ID: <40328530.2000303@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 473 bytes --]
There's a fencepost error in the GART IOMMU handling on x86_64
in the unmap path. When testing to see if the bus address is
within the IOMMU window and needs to be unmapped, the start of
the first page *beyond* the window also passes the test. This
can cause the first doubleword of the next page beyond the gatt
table to be smashed to zero, with unpredictable results depending
on what that page is used for.
Patch attached for 2.6. 2.4 patch already sent separately.
[-- Attachment #2: pci-gart-fix-2.6.patch --]
[-- Type: text/plain, Size: 523 bytes --]
--- linux-2.6.3-rc4/arch/x86_64/kernel/pci-gart.c.orig 2004-02-17 15:31:25.000000000 -0500
+++ linux-2.6.3-rc4/arch/x86_64/kernel/pci-gart.c 2004-02-17 15:33:13.000000000 -0500
@@ -521,7 +521,7 @@ void pci_unmap_single(struct pci_dev *hw
int npages;
int i;
if (dma_addr < iommu_bus_base + EMERGENCY_PAGES*PAGE_SIZE ||
- dma_addr > iommu_bus_base + iommu_size)
+ dma_addr >= iommu_bus_base + iommu_size)
return;
iommu_page = (dma_addr - iommu_bus_base)>>PAGE_SHIFT;
npages = to_pages(dma_addr, size);
reply other threads:[~2004-02-17 21:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40328530.2000303@redhat.com \
--to=jparadis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox