Re: HFSPLus driver for Linux 2.6.

Re: HFSPLus driver for Linux 2.6.

[Dylan Griffiths]

[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]

Andrew Morton wrote:
> Please send it over, and Cc linux-kernel.  It'll need to be reviewed.  Pack
> your asbestos undies ;)

...

	Hi.  I've just recently cleaned up a copy of the HFS Plus driver to 
apply to 2.6.1.  I'd like to submit it for inclusion in your -mm series, 
so I don't have to keep maintaining something that's out of tree.  HFS+ 
support is one of those things I'd like to see in 2.6 soon, so things 
like my Mac iPod and friend's HFS+ formatted firewire drives will work 
on my Linux machines :)

	I don't remember where I grabbed this driver, I only know it's much 
more current than the one at 
http://sourceforge.net/projects/linux-hfsplus.   I've used it a lot for 
my iPod on 2.4, and have had success with it on 2.6.  I haven't done 
much with the kernel, so it may or may not be entirely a sane driver 
(please review!).  The only changes I've done to the stock distribution 
were updating some prototypes for type changes and parameter additions, 
and changing kdev_t_to_nr to the newer format that the fs drivers use.

[-- Attachment #2: hfsplus-20030702.tar.gz --]
[-- Type: application/gzip, Size: 40298 bytes --]

Re: HFSPLus driver for Linux 2.6.

[Andrew Morton]

Dylan Griffiths <dylang+kernel@thock.com> wrote:
>
> 	I don't remember where I grabbed this driver, I only know it's much 
>  more current than the one at 
>  http://sourceforge.net/projects/linux-hfsplus.

Sorry, that's a showstopper.  We need to understand who the maintenance
team is, and evaluate their preparedness to maintain this code long-term.

We don't want to be adding yet another rarely-used filesystem which has no
visible maintenance team.

Re: HFSPLus driver for Linux 2.6.

[Matthias Urlichs]

Hi, Andrew Morton wrote:

> Dylan Griffiths <dylang+kernel@thock.com> wrote:
>>
>> 	I don't remember where I grabbed this driver, I only know it's much
>>  more current than the one at
>>  http://sourceforge.net/projects/linux-hfsplus.
> 
> Sorry, that's a showstopper.  We need to understand who the maintenance
> team is, and evaluate their preparedness to maintain this code long-term.
> 
That probably was http://www.ardistech.com/hfsplus/. Their latest release
is from mid-December.

> We don't want to be adding yet another rarely-used filesystem which has no
> visible maintenance team.
> 
The Mac-m68k and the Mac-PPC people would probably disagree about the
"rarely-used" part. I do agree that adding a filesystem, no matter how
widely used, without at least somebody to liaise between the kernel people
and the authors is a bad idea.

-- 
Matthias Urlichs

Re: HFSPLus driver for Linux 2.6.

[Benjamin Herrenschmidt]

On Fri, 2004-02-06 at 15:02, Andrew Morton wrote:
> Dylan Griffiths <dylang+kernel@thock.com> wrote:
> >
> > 	I don't remember where I grabbed this driver, I only know it's much 
> >  more current than the one at 
> >  http://sourceforge.net/projects/linux-hfsplus.
> 
> Sorry, that's a showstopper.  We need to understand who the maintenance
> team is, and evaluate their preparedness to maintain this code long-term.
> 
> We don't want to be adding yet another rarely-used filesystem which has no
> visible maintenance team.

It's a not-that-rarely used filesystem actually :) Been in my tree for
a few monthes and it's used by pmac users either for iPod's or for
accessing the MacOS X partitions.

It's written & maintained by Roman Zippel, and the latest snapshot is
available at http://www.ardistech.com/hfsplus/ but you probably want
to ask Roman if it's really the latest version before merging :)

One thing we absolutely need too is a port of Apple's fsck for HFS+,
currently, the driver will refuse to mount read/write a "dirty"
HFS+ filesystem to avoid corruption, but that means we have to reboot
MacOS to fsck it then... But that limitation shouldn't prevent merging
it.

I suppose it may be good to also merge Roman's cleanup/rewrite of
the old HFS filesytem...

Ben.
 

Re: HFSPLus driver for Linux 2.6.

[Andreas Schwab]

Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:

> One thing we absolutely need too is a port of Apple's fsck for HFS+,
> currently, the driver will refuse to mount read/write a "dirty"
> HFS+ filesystem to avoid corruption, but that means we have to reboot
> MacOS to fsck it then... 

Not reboot, but boot. MOL is your friend. :-)

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: HFSPLus driver for Linux 2.6.

[Matthias Urlichs]

Hi, Andreas Schwab wrote:

> Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
>> One thing we absolutely need too is a port of Apple's fsck for HFS+,
>> currently, the driver will refuse to mount read/write a "dirty"
>> HFS+ filesystem to avoid corruption, but that means we have to reboot
>> MacOS to fsck it then... 
> 
> Not reboot, but boot. MOL is your friend. :-)

OK, YOU tell that to my m68k Mac over there.  :-/

-- 
Matthias Urlichs

Re: HFSPLus driver for Linux 2.6.

[J.A. Magallon]

On 02.06, Benjamin Herrenschmidt wrote:
> On Fri, 2004-02-06 at 15:02, Andrew Morton wrote:
> > Dylan Griffiths <dylang+kernel@thock.com> wrote:
> > >
> > > 	I don't remember where I grabbed this driver, I only know it's much 
> > >  more current than the one at 
> > >  http://sourceforge.net/projects/linux-hfsplus.
> > 
> > Sorry, that's a showstopper.  We need to understand who the maintenance
> > team is, and evaluate their preparedness to maintain this code long-term.
> > 
> > We don't want to be adding yet another rarely-used filesystem which has no
> > visible maintenance team.
> 
> It's a not-that-rarely used filesystem actually :) Been in my tree for
> a few monthes and it's used by pmac users either for iPod's or for
> accessing the MacOS X partitions.
> 
> It's written & maintained by Roman Zippel, and the latest snapshot is
> available at http://www.ardistech.com/hfsplus/ but you probably want
> to ask Roman if it's really the latest version before merging :)
> 
> One thing we absolutely need too is a port of Apple's fsck for HFS+,
> currently, the driver will refuse to mount read/write a "dirty"
> HFS+ filesystem to avoid corruption, but that means we have to reboot
> MacOS to fsck it then... But that limitation shouldn't prevent merging
> it.
> 

You got it ;)

Look at http://www.opensource.apple.com/darwinsource/10.2.5/.
Get the diskdev_cmds.tar.gz, plus a patch from Roman at
http://www.ardistech.com/hfsplus/diskdev_cmds.diff.gz.

With this, I built a fsck.hfsplus + mkfs.hfsplus. I have been using them
on USB flash drives and zip disks. No real test on a several Gb disk.
But I think they will work.

There is even the source from the 10.3.2 (Panther) version for the commands,
but the current patch from Ardistech page does not apply.

But you can have a real fsck and mkfs for hfsplus.

I think it is suitable for 2.6, but of course Roman Zippel has the last
word (and should update the patch for the Panther version, if possible...)

I would really like to see this in -mm or mainline ;). It helps moving
data around...no more VFAT for me.

Hope all this helps.

-- 
J.A. Magallon <jamagallon()able!es>     \                 Software is like sex:
werewolf!able!es                         \           It's better when it's free
Mandrake Linux release 10.0 (Cooker) for i586
Linux 2.6.2-rc3-jam1 (gcc 3.3.2 (Mandrake Linux 10.0 3.3.2-4mdk))

Updated HFSplus driver for 2.6.3.

[Dylan Griffiths]

	I've updated the Linux HFS+ driver to a simple, easy to apply patch to 
your fresh 2.6.3 kernel; just go into file systems, and turn on HFSPlus 
(it's right below HFS).  You do need EXPERIMENTAL turned on to compile 
it.  I've tested it working on x86 for firewire access to an HFS+ 
formattted iPod.  Naturally, I welcome further testing by a wider 
selection of hardware combinations :)

The patch can be found here:
http://inoshiro.com/devel/linux-2.6.3-hfsplus.patch.gz