public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Friesen <cfriesen@nortelnetworks.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Raphael Rigo <raphael.rigo@inp-net.eu.org>,
	linux-kernel@vger.kernel.org, andrea@suse.de
Subject: Re: New do_mremap vulnerabitily.
Date: Wed, 18 Feb 2004 17:13:56 -0500	[thread overview]
Message-ID: <4033E3A4.80509@nortelnetworks.com> (raw)
In-Reply-To: Pine.LNX.4.58.0402180954590.2686@home.osdl.org

Linus Torvalds wrote:

> Fixed in 2.6.3 and 2.4.25 (and, I think, vendor kernels), please upgrade
> if you allow local shell access to untrusted users.

There is still a call to do_munmap() that does not check the return 
code, called from move_vma(), which in turn is called in do_mremap().

Can that call ever fail and cause Bad Things to happen?

If we know that its never going to fail, it might be useful to have a 
comment explaining it so we don't open up more exploits in the future.


Chris


-- 
Chris Friesen                    | MailStop: 043/33/F10
Nortel Networks                  | work: (613) 765-0557
3500 Carling Avenue              | fax:  (613) 765-2986
Nepean, ON K2H 8E9 Canada        | email: cfriesen@nortelnetworks.com


  reply	other threads:[~2004-02-18 22:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-18 15:26 New do_mremap vulnerabitily Raphael Rigo
2004-02-18 17:56 ` Linus Torvalds
2004-02-18 22:13   ` Chris Friesen [this message]
2004-02-18 22:26     ` Linus Torvalds
2004-02-18 23:49       ` Andrea Arcangeli
2004-02-18 23:46     ` Andrea Arcangeli
  -- strict thread matches above, loose matches on Subject: below --
2004-02-18 17:08 Ulrich Keil
2004-02-18 18:43 ` Chris Friesen
2004-02-18 20:20   ` Richard B. Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4033E3A4.80509@nortelnetworks.com \
    --to=cfriesen@nortelnetworks.com \
    --cc=andrea@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raphael.rigo@inp-net.eu.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox