From: Jeff Garzik <jgarzik@pobox.com>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux@syskonnect.de, linux-kernel@vger.kernel.org
Subject: Re: 2.6.1-rc1-mm2: warning in drivers/net/sk98lin/skge.c
Date: Wed, 18 Feb 2004 19:09:14 -0500 [thread overview]
Message-ID: <4033FEAA.1070704@pobox.com> (raw)
In-Reply-To: <20040208131413.GP7388@fs.tum.de>
Adrian Bunk wrote:
> On Tue, Jan 06, 2004 at 10:20:09AM -0800, Andrew Morton wrote:
>
>>Adrian Bunk <bunk@fs.tum.de> wrote:
>>
>>>drivers/net/sk98lin/skge.c: In function `skge_probe':
>>>drivers/net/sk98lin/skge.c:713: warning: unused variable `proc_root_initialized'
>>
>>hm, I thought I sent Jeff a fix for that.
>>
>>Yes, the definition should just be deleted.
>
>
> This warning is still present in 2.6.2-mm1 and 2.6.3-rc1.
>
> Please apply the following patch:
>
> --- linux-2.6.2-mm1/drivers/net/sk98lin/skge.c.old 2004-02-08 14:11:48.000000000 +0100
> +++ linux-2.6.2-mm1/drivers/net/sk98lin/skge.c 2004-02-08 14:11:57.000000000 +0100
> @@ -294,7 +294,6 @@
> SK_BOOL BootStringCount = SK_FALSE;
> int retval;
> #ifdef CONFIG_PROC_FS
> - int proc_root_initialized = 0;
> struct proc_dir_entry *pProcFile;
> #endif
This just went in, via SysKonnect.
So you and akpm may cheer :)
Jeff
next prev parent reply other threads:[~2004-02-19 0:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-05 8:20 2.6.1-rc1-mm2 Andrew Morton
2004-01-05 9:15 ` 2.6.1-rc1-mm2 Dax Kelson
2004-01-05 9:10 ` 2.6.1-rc1-mm2 Andrew Morton
2004-01-05 17:04 ` 2.6.1-rc1-mm2 Matthias Urlichs
2004-01-05 22:45 ` 2.6.1-rc1-mm2 (compile stats) John Cherry
2004-01-06 18:13 ` 2.6.1-rc1-mm2: warning in drivers/net/sk98lin/skge.c Adrian Bunk
2004-01-06 18:20 ` Andrew Morton
2004-02-08 13:14 ` Adrian Bunk
2004-02-19 0:09 ` Jeff Garzik [this message]
2004-01-07 15:40 ` 2.6.1-rc1-mm2: no help text for E100_NAPI Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4033FEAA.1070704@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@syskonnect.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox