From: Niraj Kumar <niraj17@iitbombay.org>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [2.6] UFS2 Read Only Patch
Date: Fri, 20 Feb 2004 12:05:51 +0530 [thread overview]
Message-ID: <4035AAC7.70701@iitbombay.org> (raw)
In-Reply-To: <20040218014422.7a1144b3.akpm@osdl.org>
Andrew,
I have updated the patch files.
Let me know if you have any more comments.
Niraj
Andrew Morton wrote:
>Niraj Kumar <niraj17@iitbombay.org> wrote:
>
>
>The patches which you have there are a bit of a disaster coding-style wise.
>
>- Use hard tabs everywhere, not eight-spaces.
>
>- No space before terminating semicolons
>
>-
>
>+ if ( (flags & UFS_TYPE_MASK) == UFS_TYPE_UFS2)
>+ {
>+ uspi->s_u2_size = fs64_to_cpu(sb, usb->fs_u11.fs_u2.fs_size);
>
> should be
>
> if ((flags & UFS_TYPE_MASK) == UFS_TYPE_UFS2) {
>
> etcetera. See Documentation/CodingStyle.
>
>
>Thanks.
>
>
prev parent reply other threads:[~2004-02-20 6:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-18 9:24 [PATCH] [2.6] UFS2 Read Only Patch Niraj Kumar
2004-02-18 9:44 ` Andrew Morton
2004-02-18 10:37 ` Niraj Kumar
2004-02-20 6:35 ` Niraj Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4035AAC7.70701@iitbombay.org \
--to=niraj17@iitbombay.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox