From: "H. Peter Anvin" <hpa@transmeta.com>
To: Andries.Brouwer@cwi.nl
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: kernel too big
Date: Fri, 20 Feb 2004 12:45:50 -0800 [thread overview]
Message-ID: <403671FE.8090005@transmeta.com> (raw)
In-Reply-To: <UTC200402201400.i1KE0AH09811.aeb@smtp.cwi.nl>
Andries.Brouwer@cwi.nl wrote:
> +
> + if ((is_big_kernel && end && end > 0xc0c00000) ||
> + (!is_big_kernel && sys_size > DEF_SYSSIZE)) {
The only issue I see here is that is_big_kernel is actually wrong, the
correct logic should be:
if ((end && end > 0xc0c00000) ||
(!is_big_kernel && sys_size > DEF_SYSSIZE))
Not that it matters much, but it's correct that way.
I would also feel a lot happier if this was actually defined
symbolically somewhere, and there was a comment connecting it to head.S.
Alternative I could take a stab at making these tables auto-generated
and therefore completely eliminate this dependency for bzImage.
-hpa
next prev parent reply other threads:[~2004-02-20 20:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-20 14:00 kernel too big Andries.Brouwer
2004-02-20 20:45 ` H. Peter Anvin [this message]
2004-02-21 4:14 ` H. Peter Anvin
-- strict thread matches above, loose matches on Subject: below --
2004-02-20 0:21 Andries.Brouwer
2004-02-20 1:04 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=403671FE.8090005@transmeta.com \
--to=hpa@transmeta.com \
--cc=Andries.Brouwer@cwi.nl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox