* [PATCH] drm/komeda: Don't flush inactive pipes
@ 2019-10-10 10:30 Mihail Atanassov
2019-10-16 8:21 ` james qian wang (Arm Technology China)
0 siblings, 1 reply; 3+ messages in thread
From: Mihail Atanassov @ 2019-10-10 10:30 UTC (permalink / raw)
To: dri-devel@lists.freedesktop.org
Cc: Mihail Atanassov, nd, james qian wang (Arm Technology China),
Liviu Dudau, Brian Starkey, David Airlie, Daniel Vetter,
linux-kernel@vger.kernel.org
HW doesn't allow flushing inactive pipes and raises an MERR interrupt
if you try to do so. Stop triggering the MERR interrupt in the
middle of a commit by calling drm_atomic_helper_commit_planes
with the ACTIVE_ONLY flag.
Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
index 8820ce15ce37..ae274902ff92 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
@@ -82,7 +82,8 @@ static void komeda_kms_commit_tail(struct drm_atomic_state *old_state)
drm_atomic_helper_commit_modeset_disables(dev, old_state);
- drm_atomic_helper_commit_planes(dev, old_state, 0);
+ drm_atomic_helper_commit_planes(dev, old_state,
+ DRM_PLANE_COMMIT_ACTIVE_ONLY);
drm_atomic_helper_commit_modeset_enables(dev, old_state);
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: drm/komeda: Don't flush inactive pipes
2019-10-10 10:30 [PATCH] drm/komeda: Don't flush inactive pipes Mihail Atanassov
@ 2019-10-16 8:21 ` james qian wang (Arm Technology China)
2019-10-21 14:03 ` Mihail Atanassov
0 siblings, 1 reply; 3+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-10-16 8:21 UTC (permalink / raw)
To: Mihail Atanassov
Cc: dri-devel@lists.freedesktop.org, David Airlie, Liviu Dudau,
linux-kernel@vger.kernel.org, nd
On Thu, Oct 10, 2019 at 10:30:07AM +0000, Mihail Atanassov wrote:
> HW doesn't allow flushing inactive pipes and raises an MERR interrupt
> if you try to do so. Stop triggering the MERR interrupt in the
> middle of a commit by calling drm_atomic_helper_commit_planes
> with the ACTIVE_ONLY flag.
>
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> index 8820ce15ce37..ae274902ff92 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> @@ -82,7 +82,8 @@ static void komeda_kms_commit_tail(struct drm_atomic_state *old_state)
>
> drm_atomic_helper_commit_modeset_disables(dev, old_state);
>
> - drm_atomic_helper_commit_planes(dev, old_state, 0);
> + drm_atomic_helper_commit_planes(dev, old_state,
> + DRM_PLANE_COMMIT_ACTIVE_ONLY);
>
Looks good to me.
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
> drm_atomic_helper_commit_modeset_enables(dev, old_state);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: drm/komeda: Don't flush inactive pipes
2019-10-16 8:21 ` james qian wang (Arm Technology China)
@ 2019-10-21 14:03 ` Mihail Atanassov
0 siblings, 0 replies; 3+ messages in thread
From: Mihail Atanassov @ 2019-10-21 14:03 UTC (permalink / raw)
To: james qian wang (Arm Technology China)
Cc: dri-devel@lists.freedesktop.org, David Airlie, Liviu Dudau,
linux-kernel@vger.kernel.org, nd
On Wednesday, 16 October 2019 09:21:24 BST james qian wang (Arm Technology China) wrote:
> On Thu, Oct 10, 2019 at 10:30:07AM +0000, Mihail Atanassov wrote:
> > HW doesn't allow flushing inactive pipes and raises an MERR interrupt
> > if you try to do so. Stop triggering the MERR interrupt in the
> > middle of a commit by calling drm_atomic_helper_commit_planes
> > with the ACTIVE_ONLY flag.
> >
> > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> > ---
> > drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> > index 8820ce15ce37..ae274902ff92 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> > @@ -82,7 +82,8 @@ static void komeda_kms_commit_tail(struct drm_atomic_state *old_state)
> >
> > drm_atomic_helper_commit_modeset_disables(dev, old_state);
> >
> > - drm_atomic_helper_commit_planes(dev, old_state, 0);
> > + drm_atomic_helper_commit_planes(dev, old_state,
> > + DRM_PLANE_COMMIT_ACTIVE_ONLY);
> >
>
> Looks good to me.
> Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
Thanks for the review, applied to drm-misc-fixes -
b88639b8e3808c948169af390bd7e84e909bde8d.
>
> > drm_atomic_helper_commit_modeset_enables(dev, old_state);
> >
>
--
Mihail
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-21 14:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-10 10:30 [PATCH] drm/komeda: Don't flush inactive pipes Mihail Atanassov
2019-10-16 8:21 ` james qian wang (Arm Technology China)
2019-10-21 14:03 ` Mihail Atanassov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox