From: Brian Gerst <bgerst@didntduck.org>
To: Chris Wedgwood <cw@f00f.org>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Run cpuid.c and msr.c through Lindent
Date: Mon, 23 Feb 2004 19:44:48 -0500 [thread overview]
Message-ID: <403A9E80.608@quark.didntduck.org> (raw)
In-Reply-To: <20040222064216.GA15101@dingdong.cryptoapps.com>
Chris Wedgwood wrote:
> On Sat, Feb 21, 2004 at 07:16:32PM -0500, Brian Gerst wrote:
>
>
>>Run cpuid.c and msr.c through Lindent to improve readability. The
>>only non-whitespace change was to add a missing semicolon after
>>module_exit().
>
>
> As much as I had poor/inconsistent formatting, gratuitous whitespace
> changes are really annoying when you have to deal with merging code
> across several kernel versions (as I have had to do) and I really
> prefer to see these things done as the code is fixed/modified.
It's excuses like this that have allowed this crap to endure for so long
without getting fixed. What patch do you have for these files that is
conflicting? I haven't seen any proposed patches for these two files in
a long time, and BK only shows one minor change in the last 6 months, so
I didn't feel that I was going to step on anyone's toes with this patch.
--
Brian Gerst
prev parent reply other threads:[~2004-02-24 0:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-22 0:16 [PATCH] Run cpuid.c and msr.c through Lindent Brian Gerst
2004-02-22 6:42 ` Chris Wedgwood
2004-02-24 0:44 ` Brian Gerst [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=403A9E80.608@quark.didntduck.org \
--to=bgerst@didntduck.org \
--cc=akpm@osdl.org \
--cc=cw@f00f.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox