[PATCH] 2.6.3 - fix for undefined mdelay in 3c505

[PATCH] 2.6.3 - fix for undefined mdelay in 3c505

[Jakub Bogusz]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

This patch fixes undefined mdelay() in 3c505 driver - at least on alpha
(maybe on other archs <linux/delay.h> is included by some other headers,
but on alpha it isn't) there was warning:

*** Warning: "mdelay" [drivers/net/3c505.ko] undefined!


-- 
Jakub Bogusz    http://cyber.cs.net.pl/~qboosh/
PLD Team        http://www.pld-linux.org/

[-- Attachment #2: linux-3c505-mdelay.patch --]
[-- Type: text/plain, Size: 397 bytes --]

fixes "*** Warning: "mdelay" [drivers/net/3c505.ko] undefined!"

--- linux-2.6.3/drivers/net/3c505.c.orig	2004-02-18 04:59:55.000000000 +0100
+++ linux-2.6.3/drivers/net/3c505.c	2004-02-25 14:54:15.000000000 +0100
@@ -106,6 +106,7 @@
 #include <linux/ioport.h>
 #include <linux/spinlock.h>
 #include <linux/ethtool.h>
+#include <linux/delay.h>
 
 #include <asm/uaccess.h>
 #include <asm/bitops.h>

Re: [PATCH] 2.6.3 - fix for undefined mdelay in 3c505

[David Weinehall]

On Wed, Feb 25, 2004 at 03:11:01PM +0100, Jakub Bogusz wrote:
> This patch fixes undefined mdelay() in 3c505 driver - at least on alpha
> (maybe on other archs <linux/delay.h> is included by some other headers,
> but on alpha it isn't) there was warning:
> 
> *** Warning: "mdelay" [drivers/net/3c505.ko] undefined!

You aren't seriously using a 3c505 on an Alpha, are you?!


Regards: David Weinehall
-- 
 /) David Weinehall <tao@acc.umu.se> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/

Re: [PATCH] 2.6.3 - fix for undefined mdelay in 3c505

[Jakub Bogusz]

On Wed, Feb 25, 2004 at 03:24:34PM +0100, David Weinehall wrote:
> On Wed, Feb 25, 2004 at 03:11:01PM +0100, Jakub Bogusz wrote:
> > This patch fixes undefined mdelay() in 3c505 driver - at least on alpha
> > (maybe on other archs <linux/delay.h> is included by some other headers,
> > but on alpha it isn't) there was warning:
> > 
> > *** Warning: "mdelay" [drivers/net/3c505.ko] undefined!
> 
> You aren't seriously using a 3c505 on an Alpha, are you?!

No, I'm not. Just trying to compile kernel with "most-module/most-yes"
config ;)
Kconfig allows to enable this, so it should build cleanly, right?


-- 
Jakub Bogusz    http://cyber.cs.net.pl/~qboosh/
PLD Team        http://www.pld-linux.org/

Re: [PATCH] 2.6.3 - fix for undefined mdelay in 3c505

[David Weinehall]

On Wed, Feb 25, 2004 at 03:32:55PM +0100, Jakub Bogusz wrote:
> On Wed, Feb 25, 2004 at 03:24:34PM +0100, David Weinehall wrote:
> > On Wed, Feb 25, 2004 at 03:11:01PM +0100, Jakub Bogusz wrote:
> > > This patch fixes undefined mdelay() in 3c505 driver - at least on alpha
> > > (maybe on other archs <linux/delay.h> is included by some other headers,
> > > but on alpha it isn't) there was warning:
> > > 
> > > *** Warning: "mdelay" [drivers/net/3c505.ko] undefined!
> > 
> > You aren't seriously using a 3c505 on an Alpha, are you?!
> 
> No, I'm not. Just trying to compile kernel with "most-module/most-yes"
> config ;)

Good, got a little worried there...

> Kconfig allows to enable this, so it should build cleanly, right?

Oh, indeed, and killing warnings is rarely a bad thing (it can sometimes
be harmful though, if it hides more serious problems.  That's not the
case here, however).


Regards: David Weinehall
-- 
 /) David Weinehall <tao@acc.umu.se> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/

Re: [PATCH] 2.6.3 - fix for undefined mdelay in 3c505

[Jeff Garzik]

applied