From: Jeff Garzik <jgarzik@pobox.com>
To: Christophe Saout <christophe@saout.de>
Cc: Andrew Morton <akpm@osdl.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][1/2] dm-crypt cleanups
Date: Thu, 26 Feb 2004 12:21:24 -0500 [thread overview]
Message-ID: <403E2B14.7060003@pobox.com> (raw)
In-Reply-To: <20040226162324.GA12597@leto.cs.pocnet.net>
Christophe Saout wrote:
> +#include <asm/atomic.h>
> #include <asm/scatterlist.h>
>
> #include "dm.h"
>
> +#define PFX "crypt: "
> +
> /*
> * per bio private data
> */
> @@ -416,7 +419,7 @@
> int key_size;
>
> if (argc != 5) {
> - ti->error = "dm-crypt: Not enough arguments";
> + ti->error = PFX "Not enough arguments";
> return -EINVAL;
> }
>
Looks good, except that PFX should be defined to "dm-crypt: " to reduce
confusion... "crypt" is rather generic, and could be construed to be
unrelated to your module.
Jeff
next prev parent reply other threads:[~2004-02-26 17:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-26 16:23 [PATCH][1/2] dm-crypt cleanups Christophe Saout
2004-02-26 16:40 ` [PATCH][2/2] dm-crypt end_io bv_offset fix Christophe Saout
2004-02-26 17:21 ` Jeff Garzik [this message]
2004-02-26 18:03 ` [PATCH][1/2] dm-crypt cleanups Christophe Saout
2004-02-26 18:13 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=403E2B14.7060003@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=christophe@saout.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox