* S390 block devs on !s390.
@ 2004-02-27 13:57 Dave Jones
2004-02-27 16:45 ` Kevin P. Fleming
0 siblings, 1 reply; 5+ messages in thread
From: Dave Jones @ 2004-02-27 13:57 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton; +Cc: Linux Kernel
This is probably useless on x86 for eg..
(Everything else in this file is dependant on some other s390 feature,
so only this one shows up). Too bad the drivers/s390/block stuff gets
source'd at all on !s390.
Dave
--- linux-2.6.3/drivers/s390/block/Kconfig~ 2004-02-27 13:54:18.000000000 +0000
+++ linux-2.6.3/drivers/s390/block/Kconfig 2004-02-27 13:54:27.000000000 +0000
@@ -13,6 +13,7 @@
config DCSSBLK
tristate "DCSSBLK support"
+ depends on ARCH_S390
help
Support for dcss block device
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: S390 block devs on !s390.
2004-02-27 13:57 S390 block devs on !s390 Dave Jones
@ 2004-02-27 16:45 ` Kevin P. Fleming
2004-02-27 16:58 ` Dave Jones
0 siblings, 1 reply; 5+ messages in thread
From: Kevin P. Fleming @ 2004-02-27 16:45 UTC (permalink / raw)
To: Dave Jones; +Cc: Linus Torvalds, Andrew Morton, Linux Kernel
Dave Jones wrote:
> This is probably useless on x86 for eg..
> (Everything else in this file is dependant on some other s390 feature,
> so only this one shows up). Too bad the drivers/s390/block stuff gets
> source'd at all on !s390.
Doesn't the config language support wrapping the entire KConfig file (or
even a higher level one) with "if ARCH_S390"? All that does is add a
"depends ARCH_S390" to everything in the file, but it would sure be a
lot easier to maintain.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: S390 block devs on !s390.
2004-02-27 16:45 ` Kevin P. Fleming
@ 2004-02-27 16:58 ` Dave Jones
2004-02-27 17:02 ` Dave Jones
0 siblings, 1 reply; 5+ messages in thread
From: Dave Jones @ 2004-02-27 16:58 UTC (permalink / raw)
To: Kevin P. Fleming; +Cc: Linus Torvalds, Andrew Morton, Linux Kernel
On Fri, Feb 27, 2004 at 09:45:37AM -0700, Kevin P. Fleming wrote:
> Dave Jones wrote:
>
> >This is probably useless on x86 for eg..
> >(Everything else in this file is dependant on some other s390 feature,
> > so only this one shows up). Too bad the drivers/s390/block stuff gets
> >source'd at all on !s390.
>
> Doesn't the config language support wrapping the entire KConfig file (or
> even a higher level one) with "if ARCH_S390"? All that does is add a
> "depends ARCH_S390" to everything in the file, but it would sure be a
> lot easier to maintain.
Sure, you force a bool to y if ARCH=S390 at the top.
That would work. Probably.
Dave
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: S390 block devs on !s390.
2004-02-27 16:58 ` Dave Jones
@ 2004-02-27 17:02 ` Dave Jones
2004-02-27 17:09 ` Kevin P. Fleming
0 siblings, 1 reply; 5+ messages in thread
From: Dave Jones @ 2004-02-27 17:02 UTC (permalink / raw)
To: Kevin P. Fleming, Linus Torvalds, Andrew Morton, Linux Kernel
On Fri, Feb 27, 2004 at 04:58:26PM +0000, Dave Jones wrote:
> > even a higher level one) with "if ARCH_S390"? All that does is add a
> > "depends ARCH_S390" to everything in the file, but it would sure be a
> > lot easier to maintain.
>
> Sure, you force a bool to y if ARCH=S390 at the top.
> That would work. Probably.
Or even easier..
(Seems to do the right thing on x86 and make menuconfig ARCH=s390
Dave
--- linux-2.6.3/drivers/s390/block/Kconfig~ 2004-02-27 17:00:07.000000000 +0000
+++ linux-2.6.3/drivers/s390/block/Kconfig 2004-02-27 17:00:27.000000000 +0000
@@ -1,3 +1,5 @@
+if ARCH_S390
+
comment "S/390 block device drivers"
depends on ARCH_S390
@@ -62,3 +64,5 @@
ioctl functions specific to the dasd driver.
This is only needed if you want to use applications written for
linux-2.4 dasd channel measurement facility interface.
+
+endif
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: S390 block devs on !s390.
2004-02-27 17:02 ` Dave Jones
@ 2004-02-27 17:09 ` Kevin P. Fleming
0 siblings, 0 replies; 5+ messages in thread
From: Kevin P. Fleming @ 2004-02-27 17:09 UTC (permalink / raw)
To: Dave Jones; +Cc: Linus Torvalds, Andrew Morton, Linux Kernel
Dave Jones wrote:
> --- linux-2.6.3/drivers/s390/block/Kconfig~ 2004-02-27 17:00:07.000000000 +0000
> +++ linux-2.6.3/drivers/s390/block/Kconfig 2004-02-27 17:00:27.000000000 +0000
> @@ -1,3 +1,5 @@
> +if ARCH_S390
> +
> comment "S/390 block device drivers"
> depends on ARCH_S390
^^^
But this is now redundant :-)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2004-02-27 17:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-02-27 13:57 S390 block devs on !s390 Dave Jones
2004-02-27 16:45 ` Kevin P. Fleming
2004-02-27 16:58 ` Dave Jones
2004-02-27 17:02 ` Dave Jones
2004-02-27 17:09 ` Kevin P. Fleming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox