Re: [PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init()

Greg Kroah-Hartman
2016-01-03T19:45:26Z

On Sun, Jan 03, 2016 at 07:50:18PM +0100, SF Markus Elfring wrote:
> >> I am a bit surprised that you do not like such source code fine-tuning.
> >
> > It's moving stuff around for no real reason, why would I like it?
>
> Can such fine-tuning result in positive effects for the run-time behaviour?

If you can not benchmark and show the proof, don't even start to claim
such a thing.

> > Did you speed up the code in a measurable way?
>
> My suggestions can result in measurable differences.

Show the proof please. That's the only way I will ever accept anything
else from you like this.

> Will it become acceptable to reduce the scope for any more variable
> definitions in further function implementations?

No.

> > Code in staging needs to be moved out of staging, and this patch does
> > nothing toward achieving that goal and it wastes people's time reviewing
> > it to see if it is correct or not.
>
> I am curious on the ways the discussed software can evolve further.

That's nice, but that's not my concern.

greg k-h