Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

SF Markus Elfring
2016-09-13T08:13:33Z

>> @@ -1064,7 +1064,7 @@ static int rbd_header_from_disk(struct rbd_device *rbd_dev,
>> header->snap_sizes = snap_sizes;
>>
>> return 0;
>> -out_2big:
>> + out_2big:
>> ret = -EIO;
>> kfree(snap_sizes);
>> free_names:
…
> Can you point where this current convention is documented?

Yes.
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51

Do you find the software update "CodingStyle: Clarify and complete chapter 7" interesting?

> Certainly not in CodingStyle, AFAICT...

I suggest to look at the current version once more.

> I know some people prefer a single space in there because it makes
> "diff -p" work better, but nowadays with "git diff" this argument is
> pretty moot.

Would you like to discuss the corresponding software evolution a bit more?

Regards,
Markus