Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

SF Markus Elfring
2016-01-02T08:10:07Z

>> Move the jump label directly before the desired log statement
>> so that the variable "err" will not be checked once more
>> after it was determined that a function call failed.
>> Use the identifier "report_failure" instead of the label "err".
>
> Why?

I suggest to reconsider the places with which such a jump label
is connected.

> The code was smart enough

Which action should really be performed after a failure was detected
and handled a bit already?

* Another condition check

* Just additional error logging

> and you're making it uglier that it needs to be.

I assume that a software development taste can evolve, can't it?

Regards,
Markus