[PATCH 13/17] s390/debug: Improve a size determination in debug_open()

SF Markus Elfring
2016-09-03T12:32:31Z

Date: Fri, 2 Sep 2016 09:02:22 +0200

* Replace the specification of a data type by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

* Improve source code layout for one function call.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/s390/kernel/debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/s390/kernel/debug.c b/arch/s390/kernel/debug.c
index a9fcf72..32ceb5e 100644
--- a/arch/s390/kernel/debug.c
+++ b/arch/s390/kernel/debug.c
@@ -636,8 +636,7 @@ debug_open(struct inode *inode, struct file *file)
rc = -ENOMEM;
goto unlock;
}
- p_info = kmalloc(sizeof(file_private_info_t),
- GFP_KERNEL);
+ p_info = kmalloc(sizeof(*p_info), GFP_KERNEL);
if (!p_info) {
debug_info_free(debug_info_snapshot);
rc = -ENOMEM;
--
2.9.3