Re: [PATCH 2/2] z2ram: Delete a jump label in z2_init()

Sergey Senozhatsky
2015-12-14T00:35:20Z

Cc Jens, Andrew, Geert

On (12/11/15 19:26), SF Markus Elfring wrote:
>
> This issue was detected by using the Coccinelle software.
>
> * Let us return directly if a call of the function "register_blkdev" failed.
>
> * Remove the jump label "err" then.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/block/z2ram.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c
> index 968f9e5..b07581d 100644
> --- a/drivers/block/z2ram.c
> +++ b/drivers/block/z2ram.c
> @@ -345,9 +345,8 @@ z2_init(void)
> if (!MACH_IS_AMIGA)
> return -ENODEV;
>
> - ret = -EBUSY;
> if (register_blkdev(Z2RAM_MAJOR, DEVICE_NAME))
> - goto err;
> + return -EBUSY;
>
> ret = -ENOMEM;
> z2ram_gendisk = alloc_disk(1);
> @@ -374,7 +373,6 @@ out_queue:
> put_disk(z2ram_gendisk);
> out_disk:
> unregister_blkdev(Z2RAM_MAJOR, DEVICE_NAME);
> -err:
> return ret;
> }

z2ram and zram are different drivers, but the change looks
ok to me.

z2ram can be improved in many ways, so my question is - do
people still use it?

-ss