Re: [PATCH 2/2] mfd: smsc-ece1099: Refactoring for smsc_i2c_probe()

SF Markus Elfring
2016-01-12T11:28:24Z

>> Which topic would you prefer for my update suggestion instead?
>
> This one.
>
> "mfd: smsc-ece1099: Refactoring for smsc_i2c_probe()"
>
> The function name and just describing the changes as "refactoring" do
> not describe the changes in a helpful way.

Would you find a subject like "mfd: smsc-ece1099: Better exception handling
in smsc_i2c_probe()" acceptable?

>>>> Acked-by: Lee Jones <lee.jones@linaro.org>
>>
>> Do you really request that I should append this tag already to messages
>> for (my adjusted) commits you can not see so far?
>
> Yes.

Interesting …

> The code looks fine,

Thanks for a bit of positive feedback.

> and if the commit log is still not up to scratch I just won't apply it. :)

Can we eventually agree on an useful message before I would dare another commit?

Will it be sufficient to delete the asterisks there?

Regards,
Markus