Re: [PATCH 00/17] s390/debug: Fine-tuning for several function implementations

Martin Schwidefsky
2016-09-05T10:31:26Z

On Sat, 3 Sep 2016 14:04:18 +0200
SF Markus Elfring <elfring@users.sourceforge.net> wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 3 Sep 2016 13:54:32 +0200
>
> Several update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (17):
> Use kmalloc_array() in debug_areas_alloc()
> Delete unnecessary braces
> Add some spaces for better code readability
> Rename jump labels in debug_areas_alloc()
> Fix jump targets in debug_info_alloc()
> Rename jump labels in debug_info_copy()
> Rename jump labels in debug_open()
> Fix a jump target in debug_register_mode()
> Return directly if a null pointer was passed to debug_unregister()
> Delete an unnecessary initialisation in debug_prolog_level_fn()
> Fix indentation in 13 functions
> Use memdup_user() rather than duplicating its implementation
> Improve a size determination in debug_open()
> Improve a size determination in debug_sprintf_format_fn()
> Improve a size determination in debug_raw_header_fn()
> Improve determination of sizes in debug_info_alloc()
> Improve another size determination in debug_info_alloc()
>
> arch/s390/kernel/debug.c | 433 ++++++++++++++++++++++-------------------------
> 1 file changed, 204 insertions(+), 229 deletions(-)

While I agree that the old code in arch/s390/kernel/debug.c does not abide to
the current coding style standards, I doubt there is much value in these patches.
To be honest I got annoyed after the third patch and stopped reading after
the forth.

NAK.

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.