[PATCH 08/17] s390/debug: Fix a jump target in debug_register_mode()

SF Markus Elfring
2016-09-03T12:23:56Z

Date: Thu, 1 Sep 2016 19:26:16 +0200

* Move an error message.

* Adjust a jump target according to the current Linux coding
style convention.

* Delete a repeated check which became unnecessary with this refactoring.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/s390/kernel/debug.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/s390/kernel/debug.c b/arch/s390/kernel/debug.c
index 1cce76a..c4a4641 100644
--- a/arch/s390/kernel/debug.c
+++ b/arch/s390/kernel/debug.c
@@ -700,14 +700,14 @@ debug_info_t *debug_register_mode(const char *name, int pages_per_area,
/* create new debug_info */

rc = debug_info_create(name, pages_per_area, nr_areas, buf_size, mode);
- if (!rc)
- goto out;
+ if (!rc) {
+ pr_err("Registering debug feature %s failed\n", name);
+ goto unlock;
+ }
debug_register_view(rc, &debug_level_view);
debug_register_view(rc, &debug_flush_view);
debug_register_view(rc, &debug_pages_view);
-out:
- if (!rc)
- pr_err("Registering debug feature %s failed\n", name);
+ unlock:
mutex_unlock(&debug_mutex);
return rc;
}
--
2.9.3