Re: [PATCH 1/2] net-qmi_wwan: Refactoring for qmi_wwan_bind()

Bjørn Mork
2016-01-02T21:38:44Z

SF Markus Elfring <elfring@users.sourceforge.net> writes:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 1 Jan 2016 17:32:07 +0100
>
> Reduce the scope for the local variable "desc" to one branch
> of an if statement.

This patch is harmless. But is also pointless.

You could at least try to explain why this must be changed. I'm not
interested in why you think it is better this way - I might agree with
that. what I am interested in is the advantage changing the code gives
us. Some analysis of the risk and work involved would also be nice. Is
this change really worth it?

Personally I am convinced that I wasted any time I used writing this,
and you wasted any time you used reading it. Sorry.

Note: This patch would have been fine if it was a natural part of some
*improvement* of the driver, i.e. a bugfix or feaure addition. As a
standalone patch I see it as noise.

Please stop the noise and start writing something useful. I'm sure you
can fix bugs instead. Wouldn't that be more interesting? More
challenging? These mindless robotic code refactoring patches are really
best left for robots.

Bjørn