Re: [PATCH 00/21] ACPI-video: Fine-tuning for several function implementations

Rafael J. Wysocki
2016-09-05T21:41:16Z

On Mon, Sep 5, 2016 at 6:42 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 5 Sep 2016 18:22:11 +0200
>
> Several update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (21):
> Use kmalloc_array() in acpi_video_get_levels()
> Return directly after a failed device query
> Delete an error message for a failed kzalloc() call
> Rename jump labels in acpi_video_get_levels()
> Delete an unnecessary initialisation in acpi_video_get_levels()
> Move four assignments in acpi_video_get_levels()
> Rename jump labels in acpi_video_bus_add()
> Improve a size determination in acpi_video_bus_add()
> Rename jump labels in acpi_video_register()
> Return directly after a failed input_allocate_device()
> Rename jump labels in acpi_video_bus_add_notify_handler()
> Delete unnecessary if statement in acpi_video_switch_brightness()
> Improve a jump target in acpi_video_switch_brightness()
> Improve a size determination in acpi_video_device_enumerate()
> Delete an unnecessary initialisation in acpi_video_device_enumerate()
> Rename jump labels in acpi_video_device_enumerate()
> Delete an unnecessary initialisation in acpi_video_init_brightness()
> Rename jump labels in acpi_video_init_brightness()
> Rename a jump label in acpi_video_device_lcd_query_levels()
> Improve a size determination in acpi_video_dev_register_backlight()
> Improve a size determination in acpi_video_bus_get_one_device()

I'd prefer this to be combined into fewer patches that each will
address several issues of one type, ie. put all label renames into one
patch, all size determination improvements into another one and so on.

Thanks,
Rafael