Re: [PATCH 1/2] mfd: smsc-ece1099: Delete an unnecessary variable initialisation in smsc_i2c_probe()

Lee Jones
2016-01-11T08:15:52Z

On Tue, 29 Dec 2015, SF Markus Elfring wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 29 Dec 2015 14:47:40 +0100
>
> The variable "ret" will be set to an appropriate value a bit later.
> Thus let us omit the explicit initialisation at the beginning.

Not sure this change is worth your or my time to be frank. I could
understand if you were a first time submitter who was dipping their
toe in the water, but for someone with 200+ patches, I really think
you should be focusing on less trivial matters.

> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/mfd/smsc-ece1099.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c
> index a4c0df7..bcac488 100644
> --- a/drivers/mfd/smsc-ece1099.c
> +++ b/drivers/mfd/smsc-ece1099.c
> @@ -36,7 +36,7 @@ static int smsc_i2c_probe(struct i2c_client *i2c,
> {
> struct smsc *smsc;
> int devid, rev, venid_l, venid_h;
> - int ret = 0;
> + int ret;
>
> smsc = devm_kzalloc(&i2c->dev, sizeof(struct smsc),
> GFP_KERNEL);

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog