From: David Howells <dhowells@redhat.com>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: dhowells@redhat.com, linux-api@vger.kernel.org,
viro@zeniv.linux.org.uk, torvalds@linux-foundation.org,
metze@samba.org, cyphar@cyphar.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] Mark AT_* path flags as deprecated and add missing RESOLVE_ flags
Date: Fri, 06 Mar 2020 14:43:42 +0000 [thread overview]
Message-ID: <4040642.1583505822@warthog.procyon.org.uk> (raw)
In-Reply-To: <20200306135632.j7kidnqm3edji6cz@wittgenstein>
Christian Brauner <christian.brauner@ubuntu.com> wrote:
> > + if (flags & O_NOFOLLOW)
> > + lookup_flags &= ~LOOKUP_FOLLOW;
>
> Odd change. But I guess you're doing it for the sake of consistency
> because of how you treat NO_TERMINAL_SYMLINKS below.
Not really. The default is to follow. Both remove the LOOKUP_FOLLOW flag and
neither set it.
David
next prev parent reply other threads:[~2020-03-06 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 17:43 [RFC][PATCH] Mark AT_* path flags as deprecated and add missing RESOLVE_ flags David Howells
2020-03-05 20:11 ` Stefan Metzmacher
2020-03-05 20:35 ` David Howells
[not found] ` <20200306134407.zjiiieg3m6ce5uts@yavin>
2020-03-06 14:56 ` David Howells
2020-03-06 13:56 ` Christian Brauner
2020-03-06 14:43 ` David Howells [this message]
[not found] ` <20200306134116.qfa2gj6os4weru7o@yavin>
2020-03-06 14:10 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4040642.1583505822@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=christian.brauner@ubuntu.com \
--cc=cyphar@cyphar.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=metze@samba.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox