[PATCH] csr1212 compile fix

[PATCH] csr1212 compile fix

[Geert Uytterhoeven]

	Hi Ben,

in_interrupt() needs #include <linux/sched.h> on some platforms (e.g. m68k).

BTW, shouldn't most of the IEEE1394 stuff depend on CONFIG_PCI? E.g.
drivers/ieee1394/dma.c uses struct pci_dev and needs pci_alloc_consistent() and
friends.

(All found while trying to enable as many drivers as possible)

--- linux-2.6.4-rc1/drivers/ieee1394/csr1212.h	2004-02-29 09:31:37.000000000 +0100
+++ linux-m68k-2.6.4-rc1/drivers/ieee1394/csr1212.h	2004-02-29 12:37:11.000000000 +0100
@@ -37,6 +37,7 @@
 #include <linux/types.h>
 #include <linux/slab.h>
 #include <linux/interrupt.h>
+#include <linux/sched.h>

 #define CSR1212_MALLOC(size)		kmalloc((size), in_interrupt() ? GFP_ATOMIC : GFP_KERNEL)
 #define CSR1212_FREE(ptr)		kfree(ptr)

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [PATCH] csr1212 compile fix

[Leon Woestenberg]

Hello Geert,

Geert Uytterhoeven wrote:
> 	Hi Ben,
> 
> in_interrupt() needs #include <linux/sched.h> on some platforms (e.g. m68k).
> 
> BTW, shouldn't most of the IEEE1394 stuff depend on CONFIG_PCI? E.g.
> drivers/ieee1394/dma.c uses struct pci_dev and needs pci_alloc_consistent() and
> friends.
> 
> (All found while trying to enable as many drivers as possible)
> 
Although most OHCI implementations are PCI based, there are embedded 
link controllers that are not (OHCI nor) PCI-based.

Here is a driver by Steve Kinneberg that shows how he removed the 
dependencies on CONFIG_PCI and written around the DMA functions.

http://mailman.uclinux.org/pipermail/uclinux-dev/2004-January/023691.html

Based on this driver (thanks again Steve if you read this) we are adding 
support for a Philips link layer device.

Regards,

Leon.