Re: [KGDB PATCH][1/7] Add / use kernel/Kconfig.kgdb

Amit S. Kale
2004-03-03T07:54:25Z

On Wednesday 03 Mar 2004 4:05 am, Pavel Machek wrote:
> Hi!
>
> > > > > It also makes core.patch dependent on 8250.patch
> > > > > Any ideas on fixing that?
> > > >
> > > > No, it's intentional. eth.patch also depends on 8250.patch.
> > >
> > > Perhaps that parts should be moved to core-lite? It should not be
> > > neccessary to have serial support...
> > >
> > > Or perhaps we want to decrease number of modules, and merge 8250 into
> > > core-lite, having one less patch to care about?

Let's keep currents splits as they are. (core-lite, i386-lite, core, i386,
x86_64, ppc, 8250, eth) It's very tempting to start merging, but that makes
it difficult to modify only a few of them and eventually user won't have the
choice of selecting only those that are needed.

> > If it's really important to not have patches depend on eachother until
> > we get to the non-lite core, i386 (and soon ppc, x86_64) patches, then
> > we should put all of the Kconfig bits in the main patch, so long as we
> > think all of the related drivers will be able to make it in as well (or
> > will move those bits out again when it's time). Or we could just
> > document dependancies and move on.
>
> I believe "put kconfig into core" is the right thing to do.

I have a different opinion. Ideally these patches are best kept completely
independent of each other. We may not be able to achieve that all the time.
Right now we have following order of patches. [core-lite, i386-lite,
8250][core, i386, x86_64, eth]. Second set depends on first. Patches in each
set are independent of each other. We anyway have this dependency because of
lite patches. So 8250 dependency should be ok.

-Amit