Re: kgdb: fix kgdbeth compilation and make it init late enough

Pavel Machek
2004-03-02T22:28:45Z

Hi!

> > CONFIG_NO_KGDB_CPUS can not be found anywhere in the patches => its
> > probably not needd any more.
>
> I don't know if we can do that. There's some funky locking stuff done
> on SMP, which for some reason can't be done to NR_CPUS (or, no one has
> tried doing that).

There was no CONFIG_NO_KGDB_CPUS anywhere else in the CVS, that means
that test could not have been right.

This could be related:

+#ifndef KGDB_MAX_NO_CPUS
+#if CONFIG_NR_CPUS > 8
+#error KGDB can handle max 8 CPUs
+#endif
+#define KGDB_MAX_NO_CPUS 8
+#endif

> > init_kgdboe can't be module_initcall; in
> > such cases it initializes after tg3 network card (and that's bad).
>
> Ah, that's an even better fix than trying to enforce link order.
>
> > Okay to commit?
>
> Second half, yes.

I already commited both, sorry.

Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]