Re: [PATCH v2 00/17] rockchip: Add rk3562 support

Kever Yang
2025-01-10T08:34:25Z

Hi Krzysztof,

Thanks very much for your review.

On 2024/12/27 15:38, Krzysztof Kozlowski wrote:
> On Tue, Dec 24, 2024 at 05:49:03PM +0800, Kever Yang wrote:
>> This patch set adds rk3562 SoC and its evb support.
>>
>> Split out patches belong to different subsystem.
>>
>> Test with GMAC, USB, PCIe, EMMC, SD Card.
>>
>> This patch set is base on the patche set for rk3576 evb1 support.
>>
>> Changes in v2:
>> - Update in sort order
>> - remove grf in cru
>> - Update some properties order
>>
>> Finley Xiao (2):
>> arm64: dts: rockchip: add core dtsi for RK3562 Soc
>> arm64: dts: rockchip: Add RK3562 evb2 devicetree
>>
>> Kever Yang (15):
>> dt-bindings: PCI: dwc: rockchip: Add rk3562 support
>> dt-bindings: mmc: Add support for rk3562 eMMC
>> dt-bindings: mmc: rockchip-dw-mshc: Add rk3562 compatible string
>> dt-bindings: power: rockchip: Add bindings for rk3562
>> dt-bindings: i2c: i2c-rk3x: Add rk3562 compatible
>> dt-bindings: gpu: Add rockchip,rk3562-mali compatible
>> dt-bindings: watchdog: Add rk3562 compatible
>> dt-bindings: spi: Add rockchip,rk3562-spi compatible
>> dt-bindings: serial: snps-dw-apb-uart: Add support for rk3562
>> dt-bindings: usb: dwc3: add compatible for rk3562
>> dt-bindings: pwm: rockchip: Add rockchip,rk3562-pwm
>> dt-bindings: rockchip: pmu: Add rk3562 compatible
>> dt-bindings: soc: rockchip: Add rk3562 syscon compatibles
>> dt-bindings: arm: rockchip: Add rk3562 evb2 board
>> dt-bindings: mfd: syscon: Add rk3562 QoS register compatible
> You squezzed here like 12 different subsystems. Some of these changes
> suggest missing drivers.
I have split out all the patches with driver change as separate patch set.
All the other dt-binding patches in this patchset is re-use the driver
without any change,
but only add a new "rockchip, rk3562-" based compatible entry, and also
no more info
need to explain in the commit message which I usually copy from commit
msg already in tree
and change the soc to rk3562.
I think this patch set will be clear enough for the new soc/board
support. So do you mean
I have to send the 1st~15th of this patchset one by one separately so
that they can reach
to different subsystems? I believe there is no much useful change for
the cc list is provide
by the tool automatically and the commit msg can update as Uwe's
suggestion:

The PWM core on Rockchip's RK3562 is the same as the one already
included in RK3328. Extend the binding accordingly to allow

compatible = "rockchip,rk3562-pwm", "rockchip,rk3328-pwm";

Thanks,
- Kever

>
> Please read basic upstreaming guide, some previous discussions and get
> internal rock-chips help so we want repeat basics over and over.
>
> Bindings are with drivers. Send them to respective subsystems.
>
> Best regards,
> Krzysztof
>
>