From: George Anzinger <george@mvista.com>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Pavel Machek <pavel@ucw.cz>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
kgdb-bugreport@lists.sourceforge.net, amit@av.mvista.com
Subject: Re: [Kgdb-bugreport] [KGDB][RFC] Send a fuller T packet
Date: Wed, 03 Mar 2004 16:36:43 -0800 [thread overview]
Message-ID: <40467A1B.9040204@mvista.com> (raw)
In-Reply-To: <20040303150802.GP20227@smtp.west.cox.net>
Tom Rini wrote:
> On Wed, Mar 03, 2004 at 11:52:47AM +0100, Pavel Machek wrote:
>
>>Hi!
>>
>>
>>
>>>>I would really like to keep this stuff out of kgdb.h since it may be
>>>>included by the user to pick up the BREAKPOINT() (which, by the way we
>>>>should standardize as I note that here it has () while not on the current
>>>>x86).
>>>
>>>It's BREAKPOINT() everywhere:
>>>$ grep BREAKPOINT include/asm-*/kgdb.h
>>>include/asm-i386/kgdb.h:#define BREAKPOINT() asm(" int $3");
>>>include/asm-ppc/kgdb.h:#define BREAKPOINT() asm(".long 0x7d821008") /* twge r2, r2 */
>>>include/asm-x86_64/kgdb.h:#define BREAKPOINT() asm(" int $3");
>>
>>Notice how it ends with ';' on everything but ppc. Perhaps it needs do
>>{ } while (0) wrapping?
>
>
> ... not that PPC works right now :) But yes, you're right.
>
I agree, lets force the ";".
--
George Anzinger george@mvista.com
High-res-timers: http://sourceforge.net/projects/high-res-timers/
Preemption patch: http://www.kernel.org/pub/linux/kernel/people/rml
prev parent reply other threads:[~2004-03-04 0:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-02 22:02 [KGDB][RFC] Send a fuller T packet Tom Rini
2004-03-02 23:28 ` [Kgdb-bugreport] " George Anzinger
2004-03-02 23:36 ` Tom Rini
2004-03-03 0:22 ` George Anzinger
2004-03-03 5:06 ` Amit S. Kale
2004-03-03 10:52 ` Pavel Machek
2004-03-03 15:08 ` Tom Rini
2004-03-04 0:36 ` George Anzinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40467A1B.9040204@mvista.com \
--to=george@mvista.com \
--cc=amit@av.mvista.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox