public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: large <large@lilymarleen.de>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: gerhard@gjaeger.de, Domen Puncer <domen@coderock.org>
Subject: Patch: Plustek scanner driver (pt_drv) port to 2.6, correction for 2.6.3
Date: Thu, 04 Mar 2004 16:19:43 +0100	[thread overview]
Message-ID: <4047490F.8050504@lilymarleen.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I recently updated from 2.6.0-test4 to 2.6.3 and noticed that my pt_drv
won't work any more. It did not load, telling me something like
missing symbol: kdev_t_to_nr

I investigated and found the problem:
the inline function kdev_t_to_nr does not exist any longer, I think it's
depr. due to the kdev device changes in 2.6.3 (2.6.2?).

ptdrv.c:
255: int minor = MINOR(kdev_t_to_nr(ip->i_rdev));

Anyway, I could not figure out what function might be it's successor, so
I simply removed the function call, leading to:

ptdrv.c:
225: int minor = MINOR(ip->i_rdev);

All kdev_t.h functions existing in 2.6.3 did only bad stuff to the
numbers so think this might be correct.

I just removed it, as it works for me (and should logically, reviewing
how the MINOR inline works now). I could not test it with more than one
scanner device, so it might still be false.

Anyone out there who can proof whether this is OK like this?

Attached the changed patch...

cu,
~  Lars
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFAR0kO7V+LJJ0V3jwRAmM6AJkBzA2VciANIfuSUsP+8TqZfpvJ0ACfdfGs
+AR+ncqsDvRuqZZXGk4L5a8=
=4DJ7
-----END PGP SIGNATURE-----

[-- Attachment #2: plustek-0.45-2.6.3.diff.gz --]
[-- Type: application/gzip, Size: 4293 bytes --]

             reply	other threads:[~2004-03-04 15:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-04 15:19 large [this message]
2004-03-04 20:12 ` Patch: Plustek scanner driver (pt_drv) port to 2.6, correction for 2.6.3 Gerhard Jaeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4047490F.8050504@lilymarleen.de \
    --to=large@lilymarleen.de \
    --cc=domen@coderock.org \
    --cc=gerhard@gjaeger.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox