From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261358AbUCHWV7 (ORCPT ); Mon, 8 Mar 2004 17:21:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261340AbUCHWV7 (ORCPT ); Mon, 8 Mar 2004 17:21:59 -0500 Received: from gateway-1237.mvista.com ([12.44.186.158]:41203 "EHLO av.mvista.com") by vger.kernel.org with ESMTP id S261358AbUCHWVz (ORCPT ); Mon, 8 Mar 2004 17:21:55 -0500 Message-ID: <404CF1F8.1030207@mvista.com> Date: Mon, 08 Mar 2004 14:21:44 -0800 From: George Anzinger Organization: MontaVista Software User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20030225 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Morton CC: "Amit S. Kale" , linux-kernel@vger.kernel.org, trini@kernel.crashing.org, pavel@ucw.cz Subject: Re: kgdb for mainline kernel: core-lite [patch 1/3] References: <200403081504.30840.amitkale@emsyssoft.com> <200403081619.16771.amitkale@emsyssoft.com> <20040308030722.01948c93.akpm@osdl.org> <200403081650.18641.amitkale@emsyssoft.com> <20040308034838.2ce64732.akpm@osdl.org> In-Reply-To: <20040308034838.2ce64732.akpm@osdl.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton wrote: > "Amit S. Kale" wrote: > >>>Let me just make sure we're taking about the same thing here. Are you >>>saying that with kgdb-lite, `info threads' is completely missing, or does >>>it just not work correctly with threads (as opposed to heavyweight >>>processes)? >> >>info threads shows a list of threads. Heavy/light weight processes doesn't >>matter. Thread frame shown is incorrect. > > > It is? I haven't noticed any problems with it here. George recently > changed it to also display the process name in the gdb output, which is > valuable. > > >>I looked at i386 dependent code again. Following code in it is incorrect. I >>never noticed it because this code is rarely used in full version of kgdb: >> >>+void sleeping_thread_to_gdb_regs(unsigned long *gdb_regs, struct task_struct >>*p) > > > There is no such function in the stub in -mm kernels. > > >>Present threads support code changes calling convention of do_IRQ. Most >>believe that to be an absolute no. > > > I see no such change in George's stub, unless I'm missing something again. Amit and I went after the problem in rather different ways... > > >>Since you consider it a must-have, I'll check whether above changes suggested >>by me make info threads listing correct in most cases. > > > The only problem I have with it is that sometimes after listing all threads > the debugger can lose control of the target and will start complaining > about communication errors. I assume the target has died. This happens > very rarely. Usually when you're about to find the bug ;) Yeah, you won't believe how much work it took to detect that ;) -- George Anzinger george@mvista.com High-res-timers: http://sourceforge.net/projects/high-res-timers/ Preemption patch: http://www.kernel.org/pub/linux/kernel/people/rml