public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Jackson <jerj@coplanar.net>
To: Arthur Corliss <corliss@digitalmages.com>
Cc: Tim Schmielau <tim@physik3.uni-rostock.de>,
	Rik van Riel <riel@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] 2.6.x BSD Process Accounting w/High UID
Date: Tue, 09 Mar 2004 11:16:45 -0500	[thread overview]
Message-ID: <404DEDED.5080308@coplanar.net> (raw)
In-Reply-To: Pine.LNX.4.58.0403041324330.20616@bifrost.nevaeh-linux.org

Arthur Corliss wrote:

> 
> 
> If the numbers we're logging are meaningless, then hell, yes, let's fix them
> all!

I believe the answer (to seamless backwards compatibility) lies in 
struct acct's ac_pad[10] member.

3 options exist that I can see:

1) put the high 16 bits in there, with a magic # (at then end of?) 
ac_pad.  THe old tools will be none the wiser, the new tools will 
autodetect which format the acct file is in.  Ugly but easy.

2) just make the uid/gid 32bits, and put a magic#  (at the end of?) 
ac_pad.  The old tools will choke, but the new tools will autodetect. 
If you push the new tools out a couple of years ahead, then merge the 
fix, acceptance will be fairly smooth.  Clean but painful.

or
3) make the split of 16 bits interim with one magic#, make the tools 
detect 3 formats, and in a few years, switch from the bastard 32bit to 
the clean one (different magic #).  This will give tools time to become 
standard.
Combines best of both of the above.

You can do the above with the time stuff too, but 10 bytes spare might 
constrain things a bit.  Heck, make the struct bigger, as long as there 
is a magic #, userspace should be ok.  Right now, "file" command can't 
tell what the heck the file is.  Bit wasteful to put magic in every 
record though.

While you're at it, make a switch for a tool that prints out 
ac_exitcode, without reading the binary acct file (or it's dump).

Cheers,
-- 
Jeremy Jackson
Coplanar Networks
http://www.coplanar.net


  parent reply	other threads:[~2004-03-09 16:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-04 18:04 [PATCH] 2.6.x BSD Process Accounting w/High UID Arthur Corliss
2004-03-04 19:51 ` Rik van Riel
2004-03-04 20:39   ` Arthur Corliss
2004-03-04 21:54     ` Tim Schmielau
2004-03-04 22:33       ` Arthur Corliss
2004-03-07 17:45         ` [PATCH] " Tim Schmielau
2004-03-07 21:20           ` Tim Schmielau
2004-03-08  0:56           ` Arthur Corliss
2004-03-08  9:08             ` Tim Schmielau
2004-03-08  9:37               ` Arthur Corliss
2004-03-09 16:16         ` Jeremy Jackson [this message]
2004-03-09 18:22           ` [PATCH] " Tim Schmielau
  -- strict thread matches above, loose matches on Subject: below --
2004-03-10  1:59 Albert Cahalan
2004-03-10  9:08 ` Tim Schmielau
2004-03-10 16:41   ` Albert Cahalan
2004-03-10 17:28     ` Tim Schmielau
2004-03-10 17:47     ` Tim Schmielau
2004-03-10 22:09       ` Albert Cahalan
2004-03-11  0:55         ` Tim Schmielau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=404DEDED.5080308@coplanar.net \
    --to=jerj@coplanar.net \
    --cc=corliss@digitalmages.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riel@redhat.com \
    --cc=tim@physik3.uni-rostock.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox