From: Bill Davidsen <davidsen@tmr.com>
To: quadong@users.sourceforge.net
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ipt_helper.c
Date: Tue, 09 Mar 2004 14:46:49 -0500 [thread overview]
Message-ID: <404E1F29.6060902@tmr.com> (raw)
In-Reply-To: <1w7Xc-6nt-11@gated-at.bofh.it>
quadong@users.sourceforge.net wrote:
> Currently, if you tell iptables to match "-m helper ! --helper ftp" it
> will match any packet from any helper other than FTP. What it should do
> is match any packet that is not from an FTP helper, included packets that
> are not from any helper (packets from master connections). Here's the
> fix:
>
> --- ipt_helper.c.old 2004-03-03 21:34:05.000000000 -0600
> +++ ipt_helper.c 2004-03-04 14:34:17.709903456 -0600
> @@ -48,7 +48,7 @@
>
> if (!ct->master) {
> DEBUGP("ipt_helper: conntrack %p has no master\n", ct);
> - return 0;
> + return info->invert;
> }
>
> exp = ct->master;
I think you can get the functionality you want with the current code,
but can you get the current functionality which you feel is in error
after applying your patch?
next parent reply other threads:[~2004-03-09 19:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1w7Xc-6nt-11@gated-at.bofh.it>
2004-03-09 19:46 ` Bill Davidsen [this message]
2004-03-04 20:42 [PATCH] ipt_helper.c quadong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=404E1F29.6060902@tmr.com \
--to=davidsen@tmr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=quadong@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox