* Re: [PATCH] ipt_helper.c
[not found] <1w7Xc-6nt-11@gated-at.bofh.it>
@ 2004-03-09 19:46 ` Bill Davidsen
0 siblings, 0 replies; 2+ messages in thread
From: Bill Davidsen @ 2004-03-09 19:46 UTC (permalink / raw)
To: quadong; +Cc: Linux Kernel Mailing List
quadong@users.sourceforge.net wrote:
> Currently, if you tell iptables to match "-m helper ! --helper ftp" it
> will match any packet from any helper other than FTP. What it should do
> is match any packet that is not from an FTP helper, included packets that
> are not from any helper (packets from master connections). Here's the
> fix:
>
> --- ipt_helper.c.old 2004-03-03 21:34:05.000000000 -0600
> +++ ipt_helper.c 2004-03-04 14:34:17.709903456 -0600
> @@ -48,7 +48,7 @@
>
> if (!ct->master) {
> DEBUGP("ipt_helper: conntrack %p has no master\n", ct);
> - return 0;
> + return info->invert;
> }
>
> exp = ct->master;
I think you can get the functionality you want with the current code,
but can you get the current functionality which you feel is in error
after applying your patch?
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] ipt_helper.c
@ 2004-03-04 20:42 quadong
0 siblings, 0 replies; 2+ messages in thread
From: quadong @ 2004-03-04 20:42 UTC (permalink / raw)
To: netfilter-devel, linux-kernel
Currently, if you tell iptables to match "-m helper ! --helper ftp" it
will match any packet from any helper other than FTP. What it should do
is match any packet that is not from an FTP helper, included packets that
are not from any helper (packets from master connections). Here's the
fix:
--- ipt_helper.c.old 2004-03-03 21:34:05.000000000 -0600
+++ ipt_helper.c 2004-03-04 14:34:17.709903456 -0600
@@ -48,7 +48,7 @@
if (!ct->master) {
DEBUGP("ipt_helper: conntrack %p has no master\n", ct);
- return 0;
+ return info->invert;
}
exp = ct->master;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-03-09 19:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1w7Xc-6nt-11@gated-at.bofh.it>
2004-03-09 19:46 ` [PATCH] ipt_helper.c Bill Davidsen
2004-03-04 20:42 quadong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox