From: Corey Minyard <minyard@acm.org>
To: Greg KH <greg@kroah.com>
Cc: Adrian Bunk <bunk@fs.tum.de>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, "Davis,
Todd C" <todd.c.davis@intel.com>,
sensors@stimpy.netroedge.com,
"Simon G. Vogl" <simon@tk.uni-linz.ac.at>
Subject: Re: 2.6.4-rc2-mm1: IPMI_SMB doesnt compile
Date: Wed, 10 Mar 2004 14:47:52 -0600 [thread overview]
Message-ID: <404F7EF8.5020402@acm.org> (raw)
In-Reply-To: <20040310190648.GB18892@kroah.com>
Greg KH wrote:
>On Wed, Mar 10, 2004 at 07:51:05PM +0100, Adrian Bunk wrote:
>
>
>>On Wed, Mar 10, 2004 at 10:01:07AM -0600, Corey Minyard wrote:
>>
>>
>>>...
>>>I have included a patch from Todd Davis at Intel that adds this function
>>>to the I2C driver. I believe Todd has been working on getting this in
>>>through the I2C driver writers, although the patch is fairly non-intrusive.
>>>
>>>However, I have no real way to test this patch.
>>>...
>>>
>>>
>>I can only confirm that it fixes the compilation...
>>
>>
>>The patch to i2c-core.c is strange:
>>
>>
>
>And dumb, and incorrect :(
>
>
>
Wrong as in: "This code will not work" or wrong as in: "don't export the
variable and the function", or both? I certainly agree that exporting
both is wrong, there should really be two inline functions with only the
variable exported, or only functions exported and the variable hidden.
That's an easy change.
However, if the code does not work, that is a bigger deal. I'm fairly
sure it works in some cases, but not sure about all.
The patch I posted is for 2.6, BTW.
-Corey
next prev parent reply other threads:[~2004-03-10 20:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-08 6:32 2.6.4-rc2-mm1 Andrew Morton
2004-03-08 16:20 ` 2.6.4-rc2-mm1 (compile stats) John Cherry
2004-03-13 14:26 ` Paul Dickson
2004-03-08 19:44 ` 2.6.4-rc2-mm1 Thomas Schlichter
2004-03-08 20:05 ` 2.6.4-rc2-mm1 Thomas Schlichter
2004-03-08 22:49 ` 2.6.4-rc2-mm1 Greg KH
2004-03-08 20:05 ` 2.6.4-rc2-mm1 Christian Borntraeger
2004-03-08 22:00 ` 2.6.4-rc2-mm1 Valdis.Kletnieks
2004-03-09 1:39 ` 2.6.4-rc2-mm1: IPMI_SMB doesnt compile Adrian Bunk
2004-03-10 16:01 ` Corey Minyard
2004-03-10 18:51 ` Adrian Bunk
2004-03-10 19:06 ` Greg KH
2004-03-10 20:47 ` Corey Minyard [this message]
2004-03-10 21:12 ` Greg KH
2004-03-10 19:11 ` Corey Minyard
2004-03-10 18:57 ` Greg KH
2004-03-09 4:44 ` 2.6.4-rc2-mm1 Valdis.Kletnieks
2004-03-09 20:07 ` [BUG] in generic.c, unloading alsa [Re: 2.6.4-rc2-mm1] Malte Schröder
2004-03-09 22:39 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2004-03-10 19:50 2.6.4-rc2-mm1: IPMI_SMB doesnt compile Davis, Todd C
2004-03-10 21:20 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=404F7EF8.5020402@acm.org \
--to=minyard@acm.org \
--cc=akpm@osdl.org \
--cc=bunk@fs.tum.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@stimpy.netroedge.com \
--cc=simon@tk.uni-linz.ac.at \
--cc=todd.c.davis@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox