* [TRIVIAL] 8139too assertions
@ 2004-03-10 22:49 Rene Herman
2004-03-12 18:40 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Rene Herman @ 2004-03-10 22:49 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Linux Kernel
[-- Attachment #1: Type: text/plain, Size: 142 bytes --]
Hi Jeff,
current placements of these asserts seems unhelpful; we've already oopsed.
Incremental to IFG patch only for line-numbers.
Rene.
[-- Attachment #2: linux-2.6.4-rc2-mm1_8139too-assert.diff --]
[-- Type: text/plain, Size: 469 bytes --]
--- linux-2.6.4-rc2-mm1/drivers/net/8139too.c~ 2004-03-10 22:58:52.000000000 +0100
+++ linux-2.6.4-rc2-mm1/drivers/net/8139too.c 2004-03-10 23:00:49.000000000 +0100
@@ -974,12 +974,11 @@
if (i < 0)
return i;
+ assert (dev != NULL);
tp = dev->priv;
+ assert (tp != NULL);
ioaddr = tp->mmio_addr;
-
assert (ioaddr != NULL);
- assert (dev != NULL);
- assert (tp != NULL);
addr_len = read_eeprom (ioaddr, 0, 8) == 0x8129 ? 8 : 6;
for (i = 0; i < 3; i++)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [TRIVIAL] 8139too assertions
2004-03-10 22:49 [TRIVIAL] 8139too assertions Rene Herman
@ 2004-03-12 18:40 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2004-03-12 18:40 UTC (permalink / raw)
To: Rene Herman; +Cc: Linux Kernel
applied to 2.4 and 2.5
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-03-12 18:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-10 22:49 [TRIVIAL] 8139too assertions Rene Herman
2004-03-12 18:40 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox