public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Williams <peterw@aurema.com>
To: root@chaos.analogic.com
Cc: "Randy.Dunlap" <rddunlap@osdl.org>,
	linux-kernel@vger.kernel.org, "Godbole,
	Amarendra (GE Consumer & Industrial)"  <Amarendra.Godbole@ge.com>
Subject: Re: (0 == foo), rather than (foo == 0)
Date: Thu, 11 Mar 2004 10:00:56 +1100	[thread overview]
Message-ID: <404F9E28.4040706@aurema.com> (raw)
In-Reply-To: <Pine.LNX.4.53.0403101324120.18709@chaos>

Richard B. Johnson wrote:
> On Wed, 10 Mar 2004, Randy.Dunlap wrote:
> 
> 
>>On Wed, 10 Mar 2004 11:46:40 +0530 Godbole, Amarendra \(GE Consumer &
>>Industrial\) wrote:
>>
>>Hi,
>>
>>While writing code, the assignment operator (=) is many-a-times
>>confused with the comparison operator (==) resulting in very subtle
>>bugs difficult to track. To keep a check on this -- the constant
>>can be written on the LHS rather than the RHS which will result
>>in a compile time error if wrong operator is used.
>>
> 
> 
> People who develop kernel code know the difference between
> '==' and '=' and are never confused my them.

And you never make typing mistakes?  That's admirable or should I say 
incredible.

> If you make
> contributions to kernel code, and write: "if (0==foo)", your
> code will be reviewed until it is obsolete and never find
> its way into the kernel. Please don't insult kernel developers
> with this kind of kid-stuff.
> 
> People who develop kernel code also know what a line-warp is.
> They put a '\n' "[Enter] key" in their text every so-often,
> maybe every 70 to 79 characters...
> 
> Cheers,
> Dick Johnson
> Penguin : Linux version 2.4.24 on an i686 machine (797.90 BogoMips).
>             Note 96.31% of all statistics are fiction.
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


-- 
Dr Peter Williams, Chief Scientist                peterw@aurema.com
Aurema Pty Limited                                Tel:+61 2 9698 2322
PO Box 305, Strawberry Hills NSW 2012, Australia  Fax:+61 2 9699 9174
79 Myrtle Street, Chippendale NSW 2008, Australia http://www.aurema.com


  parent reply	other threads:[~2004-03-10 23:04 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-10  6:16 (0 == foo), rather than (foo == 0) Godbole, Amarendra (GE Consumer & Industrial)
2004-03-10 10:34 ` Bernd Petrovitsch
2004-03-10 18:02 ` Randy.Dunlap
2004-03-10 18:33   ` Richard B. Johnson
2004-03-10 18:50     ` [OT] " David Ford
2004-03-10 19:06       ` Roland Dreier
2004-03-10 19:26         ` David Ford
2004-03-10 21:26           ` Roland Dreier
2004-03-10 22:03             ` Måns Rullgård
2004-03-11 23:12               ` Bill Davidsen
2004-03-10 19:23       ` Richard B. Johnson
2004-03-10 19:31         ` David Ford
2004-03-10 23:20           ` Frank v Waveren
2004-03-10 23:33             ` Måns Rullgård
2004-03-11  2:14             ` David Ford
2004-03-11 15:06             ` Valdis.Kletnieks
2004-03-10 23:10         ` Peter Williams
2004-03-10 21:29       ` viro
2004-03-10 22:20         ` David Ford
2004-03-10 22:42           ` Richard B. Johnson
2004-03-11  0:33             ` Micha Feigin
2004-03-11 10:47               ` Giuseppe Bilotta
2004-03-10 22:49           ` Stefan Smietanowski
2004-03-10 23:14             ` David Ford
2004-03-10 23:28               ` Måns Rullgård
2004-03-10 23:47               ` Stefan Smietanowski
2004-03-10 21:34       ` Matthew Garrett
2004-03-10 23:00     ` Peter Williams [this message]
2004-03-11  0:16       ` Randy.Dunlap
2004-03-11  2:36       ` Linus Torvalds
2004-03-11  3:08         ` Peter Williams
2004-03-11  3:19           ` Linus Torvalds
2004-03-11  4:40             ` Stefan Smietanowski
2004-03-11  9:48               ` Måns Rullgård
2004-03-11 10:29                 ` Stefan Smietanowski
2004-03-11 15:18                 ` Andreas Schwab
2004-03-11 17:42                   ` Stefan Smietanowski
2004-03-11 23:05                     ` Bill Davidsen
2004-03-11  6:50         ` Willy Tarreau
2004-03-11  7:36           ` Peter Williams
2004-03-11 15:03     ` Valdis.Kletnieks
2004-03-11 15:22       ` Richard B. Johnson
2004-03-11 15:48         ` Valdis.Kletnieks
  -- strict thread matches above, loose matches on Subject: below --
2004-03-11  4:04 Godbole, Amarendra (GE Consumer & Industrial)
     [not found] <1y5oc-8cr-1@gated-at.bofh.it>
     [not found] ` <1ygjH-3LE-31@gated-at.bofh.it>
     [not found]   ` <1ygMH-4eu-21@gated-at.bofh.it>
     [not found]     ` <1yzZ9-1qq-43@gated-at.bofh.it>
     [not found]       ` <1yAs0-1P6-7@gated-at.bofh.it>
     [not found]         ` <1yALu-288-5@gated-at.bofh.it>
2004-03-11 16:41           ` Chip Salzenberg
     [not found] <1ypPV-5N2-3@gated-at.bofh.it>
2004-03-11 16:44 ` Chip Salzenberg
2004-03-11 23:57   ` Peter Williams
2004-03-12  1:51   ` Chris Johns
2004-03-12 12:21     ` Richard B. Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=404F9E28.4040706@aurema.com \
    --to=peterw@aurema.com \
    --cc=Amarendra.Godbole@ge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rddunlap@osdl.org \
    --cc=root@chaos.analogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox