public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Ketrenos <jketreno@linux.co.intel.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Announce] Intel PRO/Wireless 2100 802.11b driver
Date: Thu, 11 Mar 2004 16:14:45 -0600	[thread overview]
Message-ID: <4050E4D5.3@linux.co.intel.com> (raw)
In-Reply-To: <20040311103754.540d9ca5@dell_ss3.pdx.osdl.net>

Stephen Hemminger wrote:
> The whole /proc/ipw2100/xxx interface is ugly and a mess.  It doesn't expose anything
> really useful that can't be found other ways and it is buggy.  It doesn't handle
> more than one device;  I know you don't make hardware with multiple chipsets now but
> will that always be true?  

We're very interested in correcting any bugs you've found in the proc code.  If 
you have any more specifics it would be greatly appreciated (steps to reproduce 
the problem, what you're seeing that is problematic, etc.)

Multiple interfaces should be supported with the current code; each one's 
entries would show up in its own /proc/ipw2100/<if_name> directory.  The single 
debug_level entry in /proc/ipw2100 sets a global level for the entire driver 
module; we felt it more useful to apply the debug level globally to all 
potential ipw2100 devices than on a per device basis.  In the event that someone 
does have multiple ipw2100's in their machine and they want to be able to set 
the debug_level explicitly on a per device basis, we can accomodate that rather 
quickly in the code.  I'm interested in hearing other's opinions on this and am 
very willing to change the code if appropriate.

 > Also, it forgets to do properly set module owner.

Good catch; I'll fix it in the next snapshot.

> If you really have to keep the interface could you consider putting it in sysfs.
> Something like /sys/class/net/eth0/ipw2100/xxx with one value per file.
> The way to do that is with attribute groups.

Transitioning to sysfs is one of the goals as the project develops.

That said, we have a development mailing list set up for the project if you're 
interested in helping us improve the driver.  You can subscribe to that list 
here <http://lists.sourceforge.net/mailman/listinfo/ipw2100-devel>

Thanks for the feedback.

James

  reply	other threads:[~2004-03-11 22:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-09 20:24 [Announce] Intel PRO/Wireless 2100 802.11b driver James Ketrenos
2004-03-09 20:57 ` Arjan van de Ven
2004-03-09 22:01   ` James Ketrenos
2004-03-09 23:48     ` Marcel Holtmann
2004-03-09 21:05 ` Timothy Miller
2004-03-09 21:12 ` Dax Kelson
2004-03-10  2:46   ` James Ketrenos
2004-03-10  8:15   ` vda
2004-03-10  8:38     ` Jeff Garzik
2004-03-10 17:31       ` Timothy Miller
2004-03-10 17:26         ` Jeff Garzik
2004-03-12  0:32         ` Lincoln Dale
2004-03-11  1:07       ` Joel Jaeggli
2004-03-10 12:35     ` bert hubert
2004-03-10 18:06     ` Disconnect
2004-03-11 22:45     ` Bill Davidsen
2004-03-10  7:52 ` Jan De Luyck
2004-03-11  6:23   ` Jan De Luyck
2004-03-11  7:48     ` James Ketrenos
2004-03-11  8:05       ` Jan De Luyck
2004-03-11 18:37 ` Stephen Hemminger
2004-03-11 22:14   ` James Ketrenos [this message]
2004-03-11 22:27 ` Bill Davidsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4050E4D5.3@linux.co.intel.com \
    --to=jketreno@linux.co.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox