Re: [PATCH 7/7] clk: qcom: gcc: Add support for Global Clock Controller

[Krzysztof Kozlowski <krzk@kernel.org>]

On 17/07/2025 11:57, Abel Vesa wrote:
> On 25-07-16 20:50:17, Pankaj Patil wrote:
>> From: Taniya Das <taniya.das@oss.qualcomm.com>
>>
>> Add support for Global clock controller for Glymur platform.
>>
>> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
>> Signed-off-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
>> ---
>>  drivers/clk/qcom/Kconfig      |   10 +
>>  drivers/clk/qcom/Makefile     |    1 +
>>  drivers/clk/qcom/gcc-glymur.c | 8623 +++++++++++++++++++++++++++++++++
>>  3 files changed, 8634 insertions(+)
>>  create mode 100644 drivers/clk/qcom/gcc-glymur.c
>>
>> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
>> index 051301007aa6..1d9e8c6aeaed 100644
>> --- a/drivers/clk/qcom/Kconfig
>> +++ b/drivers/clk/qcom/Kconfig
>> @@ -645,6 +645,16 @@ config SAR_GPUCC_2130P
>>  	  Say Y if you want to support graphics controller devices and
>>  	  functionality such as 3D graphics.
>>  
>> +config SC_GCC_GLYMUR
> 
> Wait, are we going back to this now?
> 
> X Elite had CLK_X1E80100_GCC, so maybe this should be CLK_GLYMUR_GCC
> then.


Yeah, the SC is meaningless here, unless you call it CLK_SC8480XP_GCC,
so the authors need to decide on one naming. Not mixtures..


Best regards,
Krzysztof