From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
jack@suse.cz, chris@linuxinfotag.de
Subject: Re: [PATCH][BUG 10227] readahead ret value fix
Date: Fri, 14 Mar 2008 19:42:15 +0800 [thread overview]
Message-ID: <405494956.21991@ustc.edu.cn> (raw)
Message-ID: <E1Ja8Ih-0005kr-0V@localhost> (raw)
In-Reply-To: <20080314104906.GA2898@darkstar.te-china.tietoenator.com>
On Fri, Mar 14, 2008 at 06:49:06PM +0800, Dave Young wrote:
> If the page_offset > end_index, the return value should be updated to 0,
> avoiding the redundant read_pages
No, we don't need to fix it, hehe.
It's really trivial overhead.
The principle is to not add dispensable code :-)
Thank you,
Fengguang
prev parent reply other threads:[~2008-03-14 11:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 10:49 [PATCH][BUG 10227] readahead ret value fix Dave Young
2008-03-14 11:08 ` Dave Young
[not found] ` <E1Ja8Ih-0005kr-0V@localhost>
2008-03-14 11:42 ` Fengguang Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=405494956.21991@ustc.edu.cn \
--to=wfg@mail.ustc.edu.cn \
--cc=akpm@linux-foundation.org \
--cc=chris@linuxinfotag.de \
--cc=hidave.darkstar@gmail.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox