From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161220AbcHELEF (ORCPT ); Fri, 5 Aug 2016 07:04:05 -0400 Received: from gloria.sntech.de ([95.129.55.99]:51807 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934968AbcHELDi (ORCPT ); Fri, 5 Aug 2016 07:03:38 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Chris Zhong Cc: dianders@chromium.org, tfiga@chromium.org, yzq@rock-chips.com, groeck@chromium.org, wulf@rock-chips.com, marcheu@chromium.org, linux-rockchip@lists.infradead.org, Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: rockchip: mark rk3399 hdcp_noc and pclk_vio_grf as critical Date: Fri, 05 Aug 2016 13:02:48 +0200 Message-ID: <4055149.Zs66lEhv2I@diego> User-Agent: KMail/4.14.10 (Linux/4.6.0-1-amd64; KDE/4.14.22; x86_64; ; ) In-Reply-To: <1470209784-2665-1-git-send-email-zyw@rock-chips.com> References: <1470209784-2665-1-git-send-email-zyw@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chris, Am Mittwoch, 3. August 2016, 15:36:24 schrieb Chris Zhong: > The Type-C DP need these clocks: aclk_hdcp_noc, hclk_hdcp_noc, > pclk_hdcp_noc, pclk_vio_grf. Mark them as critical to avoid someone > close them. > > Signed-off-by: Chris Zhong > > --- > > drivers/clk/rockchip/clk-rk3399.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/clk/rockchip/clk-rk3399.c > b/drivers/clk/rockchip/clk-rk3399.c index 78e51cb..6c8ed25 100644 > --- a/drivers/clk/rockchip/clk-rk3399.c > +++ b/drivers/clk/rockchip/clk-rk3399.c > @@ -1466,6 +1466,9 @@ static struct rockchip_clk_branch > rk3399_clk_pmu_branches[] __initdata = { > > static const char *const rk3399_cru_critical_clocks[] __initconst = { > "aclk_cci_pre", > + "aclk_hdcp_noc", > + "hclk_hdcp_noc", > + "pclk_hdcp_noc", > "pclk_perilp0", > "pclk_perilp0", > "hclk_perilp0", ok, we have marked all other noc (interconnect) clocks as critical, so this looks good. > @@ -1485,6 +1488,7 @@ static const char *const rk3399_cru_critical_clocks[] > __initconst = { "gpll_hclk_perilp1_src", > "gpll_aclk_perilp0_src", > "gpll_aclk_perihp_src", > + "pclk_vio_grf", I don't necessarily agree with this one. It seems for the analogix-dp the preferred way is to have the driver handle its needed clock, see "[PATCH v1 6/6] drm/rockchip: dw_hdmi: introduce the pclk for grf" [0] Heiko [0] https://patchwork.kernel.org/patch/9223331/