From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6261AC433F5 for ; Tue, 29 Mar 2022 15:03:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238223AbiC2PEq (ORCPT ); Tue, 29 Mar 2022 11:04:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238217AbiC2PEm (ORCPT ); Tue, 29 Mar 2022 11:04:42 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5B3518C0DC for ; Tue, 29 Mar 2022 08:02:59 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id r7so10497487wmq.2 for ; Tue, 29 Mar 2022 08:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=moLFBme3l1MFSRqv3HwjWFIls+K2bshAzpdyHy0MNyk=; b=NjZgkuVQxWE5kDMvScRuxs+9TFNgXSyY+QQCXH6ML3o//up532bifrBrmytwgWxciz aLk0JzAznjSCGyAgCoDPBtfKxaxGFqv4E7AGvY0xm25dtMcMiuKVnHiKuklpYR4RkDMs wra+3Glwhas7Hs5uHVUqz3lkYqmv+Gc1IiorsAcvH4lfl6cz/3MWu6jPL7lyXoqa/8xI ZY8YLtPwbHgcIopLU1rWyNvQ8JhrTCkl0IhSnQ2elJ0qRfIDXq5bSwfESxE/kXGe3+l7 baxKRnMq+OFDOTwZfyqorUsTndZ2tUNa4AwBnEXEVEQQqHIO7FAUqyWGEjJtNPX8RbG9 Mc/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=moLFBme3l1MFSRqv3HwjWFIls+K2bshAzpdyHy0MNyk=; b=A4PE8sKcNzc3hDhRfOMXe/AnqGruNhzFmbh01khDx2nnfJWQ7x9zpsHTi7BQn5CY9L 9bfINH5fIy5/m5yUuxpRTgArgs30GYnXPsj1cgATSb9zy28uXfaTwUD2TX5CXAICG8hk /AcoF9QlMNc3JEZdOIHgFtFMTb0J1Vr3teznTjdH7KPQXgJwOOdw9PqvRidrdrekHtx8 pDbgnMPA7KXnOIODJZgKibPFh07Jo+uZYTwRPDxNVIBX0J6Fgmds6qLLFWs9KmAYfJud /F5DAlLscbT/uJMQs0ZcDXWvWj4Ung2EFIAgZ/GMrelbXLGwFZDIT1EdvcxVkQIFr14t /XXg== X-Gm-Message-State: AOAM530BUbq5C4/9kymJkntTTZAVPIvwZv8dPXrA3pBb60ssDqYdR9gR J721CplAte2agKkbin4HDxY= X-Google-Smtp-Source: ABdhPJyLlZsIm4LXUAyjPuGNL42MJl4z/IdaIzJgFCWreFpO5AzXezgcyOPB95pFjd+FJPKcKl/rgQ== X-Received: by 2002:a05:600c:1d95:b0:38c:f943:c20c with SMTP id p21-20020a05600c1d9500b0038cf943c20cmr62758wms.19.1648566178086; Tue, 29 Mar 2022 08:02:58 -0700 (PDT) Received: from leap.localnet (host-95-249-145-232.retail.telecomitalia.it. [95.249.145.232]) by smtp.gmail.com with ESMTPSA id r65-20020a1c4444000000b0038c48dd23b9sm3724849wma.5.2022.03.29.08.02.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Mar 2022 08:02:56 -0700 (PDT) From: "Fabio M. De Francesco" To: Dan Carpenter Cc: Greg Kroah-Hartman , Benjamin Philip , Bart Van Assche , "Martin K. Petersen" , "Eric W. Biederman" , Colin Ian King , Samuel =?ISO-8859-1?Q?Sj=F6berg?= , Charlie Sands , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, ira.weiny@intel.com Subject: Re: [PATCH v2] staging: rts5208: Convert kmap() to kmap_local_page() Date: Tue, 29 Mar 2022 17:02:54 +0200 Message-ID: <4055501.1IzOArtZ34@leap> In-Reply-To: <20220329091827.GY3293@kadam> References: <20220329055539.29299-1-fmdefrancesco@gmail.com> <20220329091827.GY3293@kadam> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On marted? 29 marzo 2022 11:18:27 CEST Dan Carpenter wrote: > On Tue, Mar 29, 2022 at 07:55:39AM +0200, Fabio M. De Francesco wrote: > > diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c > > index 805dc18fac0a..56b6cc845619 100644 > > --- a/drivers/staging/rts5208/rtsx_transport.c > > +++ b/drivers/staging/rts5208/rtsx_transport.c > > @@ -92,13 +92,11 @@ unsigned int rtsx_stor_access_xfer_buf(unsigned char *buffer, > > while (sglen > 0) { > > unsigned int plen = min(sglen, (unsigned int) > > PAGE_SIZE - poff); > > - unsigned char *ptr = kmap(page); > > > > if (dir == TO_XFER_BUF) > > - memcpy(ptr + poff, buffer + cnt, plen); > > + memcpy_to_page(page + poff, 0, buffer + cnt, plen); > > You meant: > > memcpy_to_page(page, poff, buffer + cnt, plen); > Yes, correct. I meant exactly what you wrote. It's the first time that I use these API and, after 30 seconds look at their prototypes, I thought that either have the same semantics. I don't yet know if I'm wrong. However, even if either were correct, yours would be more consistent and elegant. Therefore, I am going to change these calls and submit a v3. Thanks for your review, Fabio M. De Francesco > > else > > - memcpy(buffer + cnt, ptr + poff, plen); > > - kunmap(page); > > + memcpy_from_page(buffer + cnt, page + poff, 0, plen); > > Same. > > regards, > dan carpenter > >