From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 067393F076F for ; Mon, 18 May 2026 13:44:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779111900; cv=none; b=pY2bAAdJrF2YkcXgys6WijmLo+AGplD4Z4dPcKAM0MSjfxYGir/Kl6vyx3IGY1cEhn4K3cnoctTVcY7KrSurPdU/7FiDmB3kWjqjEvzTvxRGpiLuIZqpVxYQ7qYL2wnq12GYSuU6BKCmoe1pwcL5Ix5neYKB1oDuE7Sk1nX8188= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779111900; c=relaxed/simple; bh=lHvda2NbFgW89aGtBUROhxE/JDE+sRSb8r8BbzUoSLE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pefpzyeSExjtK8+Hhi9NleK26iqXnK0cETI6MjwZOFKKVtjL3lDtOfjlhPalVlon1hAUFU8ERdlUU3xEvsutg3r3dCSbCaceMlmCBlAybSCs1KWaHMxqQRhU4ue8zSAV091+YllGel4W4fSs2e45CVrbvC6dkU0DG2U6BdVHBxI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oz6SJ0q2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=D1nlDL6N; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oz6SJ0q2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="D1nlDL6N" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64IBwHrx1251662 for ; Mon, 18 May 2026 13:44:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VyevxfIizzgDB7/P56OEYcISboPpJOah7P6lWmyc20Y=; b=oz6SJ0q2ihCIsKhS izEDZsnIZ/68zpI+HyMpKXsv33iN1nCp0OST0FF+9FZGCNB5FfUC5kNt+Ni6xPdg ChhH0eMonqSRRpRIidoEZYkb/axB7ewS0aQMzipvLrQuPh0Uq0PzcTL4STZdtMCA +l/J5qdEKHydRjm6pxR5n3/qXUmBQyuKogQKMtZH/itAA30B74l2M/b3m2OX21t/ J9J9t5XFaenSu/E67MCXQjzObmC1IKea7TpmbyxD1cP21mFYjfrl1mtFCcGL8X5B nCVJ5PcCMLykSLrx/4Uu/QmE/HLV//OZJ9kUnBtMUHo/zFlItzUHYRgE1v7wQYFv 6eUxqg== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e82c0gda2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 13:44:54 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50f1b94ac9dso11635601cf.1 for ; Mon, 18 May 2026 06:44:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779111893; x=1779716693; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VyevxfIizzgDB7/P56OEYcISboPpJOah7P6lWmyc20Y=; b=D1nlDL6NM3Dj2yLgQJhqAGTwi4+zKVYe+DgFnofdA05NYWLzvmRNbu8wU5zXlS0PrF LA+LqBDF3wsJ6l6KQLdk3Vn3FJuXpNidB/CR3ezifYBWMXZfeOOq+tTIXctzApUpR62E /Qip10N3maiPwrUTKY89Kw0cdx1PeetZ+x15mvAwLVe+6ABf/46n8TrP+WizeoeBb3vP HcLwx/KCvu+J/gCp/QiXKjVD7enqwGYarInZZlhBOSTh1Hf1TILP0MT/dsfdoOV1+cyS J0071sZcf13k3xRhacCz9NQMxqyHk2Ty/HT1QAIZCMbT0mV5I9KMnfcgAma+npYpa4JG i2rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779111893; x=1779716693; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VyevxfIizzgDB7/P56OEYcISboPpJOah7P6lWmyc20Y=; b=EzGgURQoTeC7uuchjaj3lKt5rjFX7SkNuXN9JkeN9lx7vtjDCmkB7iZs3gzugeVle/ knmAuwDaYl9MJ0pRW1QONU8Gy1wy9oEw8ZAtJvPs7/2L77uCW5RFST4FcDW0GzOjaPWl LrHWJ8nSUxzMsvogCdsR7Bh4fg12da47egI3yLH3qfgCSkVcZ9gHJp1OB95wujJZKuX9 FZ+/lv5vz30y1QyOZ+yUTpaPRM3oENV3Dj+jUL6zGxqXQ4h2ub/DrXV1jYzOC5IXoO+f UFepWGrsSo3FqzCuLCwSMD80ZMDgM1MNPAh18VE5A0OAgX6yBfxz4odCUDS/RKQ9zWW3 V3dw== X-Gm-Message-State: AOJu0YylLFBIB7K00anRpxxHJ/cLiE5mx3MUnPSbanQPO92beVbyCG/y H+z+p9CCADSBwKX298nYv00tThBrdbx7dONlLkNXQEOxJQgl+uTsmXA6RxUsAJaZ0eUdoL+YXQc GUCywEiyTiVkjHn73Aew2vbB8Ghm2/E2YOvzCnP1ZZGpwnV4T9OpnttuIqbWYt3XfgRw= X-Gm-Gg: Acq92OEoGyzBdqne3SCJzZDIdbhYZN+plSO22APrSS0YpDoiS0ejWlFJdOubE0qCxen i6xecI7PViu8+eeR0uKKpzg605lfdEpGmMKc7/yaX8y/0GEQ4ndnFmqUQ8b4lapSsN1qYOhW08o MZDPwoQZ1Yhenq+RGFlDn4C0qpx5+pTkufh9q07CJUTMfsX08pFJV74XFbMigXjduNzqi4Rzgsx pz2iUerW7qMDenofYf2KyZB0gWWesEEWZX4Y39DXRXzMzfV/zQnMSs+BHj6XVoAUcjgfEaei8/V nX0kek7d8BtTMwdYJOe6bjrsAxGR5qI1Su5J6Ai7XkQE5qXCk/UkUX2P66YQ9g008MYctPrlbB5 1c4AZpuJLV7yi0RzfZW1KmOJUR2M5vd9Q1cDQfZS5UCBgPj66rxoYU+ZyuKtX+pipSxJeSmh8UA HA6g0= X-Received: by 2002:a05:622a:11ce:b0:513:43ce:eaa3 with SMTP id d75a77b69052e-5165a202f87mr153359551cf.6.1779111893420; Mon, 18 May 2026 06:44:53 -0700 (PDT) X-Received: by 2002:a05:622a:11ce:b0:513:43ce:eaa3 with SMTP id d75a77b69052e-5165a202f87mr153359221cf.6.1779111892776; Mon, 18 May 2026 06:44:52 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68310b52675sm5248215a12.8.2026.05.18.06.44.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 06:44:52 -0700 (PDT) Message-ID: <4056582b-a6d5-4fdf-8cce-5e2d20b00a08@oss.qualcomm.com> Date: Mon, 18 May 2026 15:44:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] spi: qcom-geni: Add trace events for Qualcomm GENI SPI driver To: Praveen Talari , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, mukesh.savaliya@oss.qualcomm.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260512-add-tracepoints-for-qcom-geni-spi-v2-0-3b184068ecf9@oss.qualcomm.com> <20260512-add-tracepoints-for-qcom-geni-spi-v2-2-3b184068ecf9@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260512-add-tracepoints-for-qcom-geni-spi-v2-2-3b184068ecf9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDEzNCBTYWx0ZWRfX4Jesw0RZ8VLj cq3miaWfwh2SXV4LepTjtfX3mY2HvsVD3UagEZJw7OiGYsz/SHOIxClyFg3dTMSU6p3WNPJ50Vn pI3Fdk+Lw6I7sWvdNcbvd1nMNrzBPNngSKcpF35NFSzCA73FI24akanGVQHEseJVabJs3WdRkxi jIo+3NlKt0DO/SqlU2b/F+imQgw6P4DVtfA2imJx7BFAWaVVg9e4tAiVdUlqfTtaotOCsi/kx1+ A8URV6eIksUWvBQTcZh2NzwUhdtak6uCtwpfWYvLCUUzxblf7Gy8zgpqxqOV2yLHXbvkxgqSWqG myLX96jnrdi6kY8RK2MtSZgUxqCyF6fw1dmo57sGfA/57V2ZUmjntLUFQoOE/T8BdSFawSe3KET 2QexaQmOaut8rb1j7LhnaIIIp9m7pZYpjJmMXj7U8KV0Ew2ykd+85UMluBNTRkjrQFVC3yPjk// JuA4EWcxgcK8G4mkXKw== X-Authority-Analysis: v=2.4 cv=A5Jc+aWG c=1 sm=1 tr=0 ts=6a0b17d6 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=-Sl1Rx_dgo55JVPCJUEA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: vvcqgFkNz4wqS_fMDsUIi5rcWfiGp9jb X-Proofpoint-ORIG-GUID: vvcqgFkNz4wqS_fMDsUIi5rcWfiGp9jb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_03,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 impostorscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180134 On 5/12/26 8:12 AM, Praveen Talari wrote: > Add tracepoints to the Qualcomm GENI (Generic Interface) SPI driver. > These trace events enable runtime debugging and performance analysis > of SPI operations. > > The trace events capture SPI clock configuration, FIFO parameters, > transfer details, interrupt status. > > Usage examples: > > Enable all SPI traces: > echo 1 > /sys/kernel/tracing/events/spi/enable > echo 1 > /sys/kernel/debug/tracing/events/qcom_geni_spi/enable > cat /sys/kernel/debug/tracing/trace_pipe > > Example trace output: > > 1003.956560: spi_message_submit: spi16.0 000000001b20b93c > 1003.956642: spi_controller_busy: spi16 > 1003.956643: spi_message_start: spi16.0 000000001b20b93c > 1003.956646: geni_spi_fifo_params: 888000.spi: cs=0 mode=0x00000020 > mode_changed=0x00000007 cs_changed=0 > 1003.956647: spi_set_cs: spi16.0 activate > 1003.956648: spi_transfer_start: spi16.0 00000000ea1cf8b6 len=16 > tx=[4c-80-e4-ca-68-4d-95-aa-ee-99-ae-d7-69-e9-5f-39] > rx=[00-00-00-00-00-00-00-00-00-00-00-00-00-00-00-00] > 1003.956653: geni_spi_clk_cfg: 888000.spi: req_hz=20000000 > sclk_hz=100000000 clk_idx=5 clk_div=5 bpw=8 > 1003.956691: geni_spi_transfer: 888000.spi: len=16 m_cmd=0x00000003 > 1003.956708: geni_spi_irq: 888000.spi: m_irq=0x08000081 > dma_tx=0x00000000 dma_rx=0x00000000 > 1003.956717: spi_transfer_stop: spi16.0 00000000ea1cf8b6 len=16 > tx=[4c-80-e4-ca-68-4d-95-aa-ee-99-ae-d7-69-e9-5f-39] > rx=[4c-80-e4-ca-68-4d-95-aa-ee-99-ae-d7-69-e9-5f-39] > 1003.956717: spi_set_cs: spi16.0 deactivate > 1003.956718: spi_message_done: spi16.0 000000001b20b93c len=16/16 Same feedback regarding this part of the commit message as on the UART patch Reviewed-by: Konrad Dybcio Konrad