public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* RE: 2.6.3 adaptec I2O will not compile
@ 2004-02-26 14:56 Salyzyn, Mark
  2004-03-02  6:52 ` Jaco Kroon
  0 siblings, 1 reply; 9+ messages in thread
From: Salyzyn, Mark @ 2004-02-26 14:56 UTC (permalink / raw)
  To: David Lang, Jaco Kroon; +Cc: Adrian Bunk, Linux Kernel Mailing List

My code fragment has (original multiversion and version in 2.4.24):

/*
 * scsi_unregister will be called AFTER we return.
 */
static int adpt_release(struct Scsi_Host *host)
{
        adpt_hba* pHba = (adpt_hba*) host->hostdata[0];
//      adpt_i2o_quiesce_hba(pHba);
        adpt_i2o_delete_hba(pHba);
        return 0;
}

So I am unsure as to how *that* (the scsi_unregister call) got in there
in the 2.6.3 stream. adpt_i2o_queisce was commented out in version 2.4.5
of the driver (Prior to the `historical documents' and at least the
in-box driver for RH7.3). It was not part of the 2.6.2 tree I based my
patch on and not part of the submitted 2.6 patch for the dpt_i2o driver.

adpt_i2o_quiesce tells the adapter to stop all activity, including
builds, and is a blocking command with a 4 minute timeout.

Sincerely -- Mark Salyzyn

-----Original Message-----
From: David Lang [mailto:david.lang@digitalinsight.com] 
Sent: Thursday, February 26, 2004 5:24 AM
To: Salyzyn, Mark; Jaco Kroon
Cc: Adrian Bunk; Linux Kernel Mailing List
Subject: Re: 2.6.3 adaptec I2O will not compile

Mark, do you have any comments on this?

On Thu, 26 Feb 2004, Jaco Kroon wrote:

> Date: Thu, 26 Feb 2004 01:28:14 -0800
> From: Jaco Kroon <jkroon@cs.up.ac.za>
> To: David Lang <david.lang@digitalinsight.com>
> Cc: Adrian Bunk <bunk@fs.tum.de>,
>      Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
> Subject: Re: 2.6.3 adaptec I2O will not compile
>
> David Lang wrote:
>
> >I received a post from Mark Salyzyn with a new driver that does
> compile,
> >he said that he has submitted the patches (I didn't get a chance to
try
> >the new kernel yet, I expect to do that shortly and will report any
> >problems)
> >
> >D
> >
> Somebody just mailed me a patch too, but I found the following
> discrepancy:
>
> /*
>  * scsi_unregister will be called AFTER we return.
>  */
> static int adpt_release(struct Scsi_Host *host)
> {
>     adpt_hba* pHba = (adpt_hba*) host->hostdata[0];
> //  adpt_i2o_quiesce_hba(pHba);
>     adpt_i2o_delete_hba(pHba);
>     scsi_unregister(host);
>     return 0;
> }
>
> This is used to release the host, now read the comment, and then the
> line just before the return.  This line was added by the patch, which
> also commented out the quiesce line.  Is it possible to get any
> confirmation on how this is supposed to function?
>
> Jaco
>
> ===========================================
> This message and attachments are subject to a disclaimer. Please refer
> to www.it.up.ac.za/documentation/governance/disclaimer/ for full
> details.
> Hierdie boodskap en aanhangsels is aan 'n vrywaringsklousule
onderhewig.
> Volledige besonderhede is by
> www.it.up.ac.za/documentation/governance/disclaimer/ beskikbaar.
> ===========================================
>
>

-- 
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: dm-crypt, new IV and standards
@ 2004-02-20 21:26 James Morris
  2004-02-20 21:52 ` 2.6.3 adaptec I2O will not compile David Lang
  0 siblings, 1 reply; 9+ messages in thread
From: James Morris @ 2004-02-20 21:26 UTC (permalink / raw)
  To: Jean-Luc Cooke
  Cc: Christophe Saout, Carl-Daniel Hailfinger,
	Linux Kernel Mailing List, Andrew Morton

On Fri, 20 Feb 2004, Jean-Luc Cooke wrote:

> If others on the list care to do this, I'll give recommendation on how to 
> implement the security (hmac, salt, iteration counts, etc).  But I think
> this may break backward compatibility.  Can anyone speak to this?

Please focus your recommendations on security, not backward compatibility
with something that is new to the kernel tree, broken and maintainerless.

Thanks,


- James
-- 
James Morris
<jmorris@redhat.com>



^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2004-03-16 17:42 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <547AF3BD0F3F0B4CBDC379BAC7E4189F38D76F@otce2k03.adaptec.com>
2004-03-16 14:20 ` 2.6.3 adaptec I2O will not compile Jaco Kroon
2004-02-26 14:56 Salyzyn, Mark
2004-03-02  6:52 ` Jaco Kroon
  -- strict thread matches above, loose matches on Subject: below --
2004-02-20 21:26 dm-crypt, new IV and standards James Morris
2004-02-20 21:52 ` 2.6.3 adaptec I2O will not compile David Lang
2004-02-25 16:25   ` Adrian Bunk
2004-02-26  8:02     ` Jaco Kroon
2004-02-26  8:08       ` David Lang
2004-02-26  9:28         ` Jaco Kroon
2004-02-26 10:24           ` David Lang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox