From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 006CC3D1AA0 for ; Tue, 23 Jun 2026 11:02:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782212535; cv=none; b=buxRjrdyjBprjjJvATatZsb1P+AtiLDfEch3H/sE1CawyYzBEMCMWcr5WY/8AtMoc9De38uKWtMUu+bfoDqo1cC9Dtu6LGF/czGdDt/mJ8y8u9APBOCE9Ou6ScAERI2OTX+8DYb/ItzjXX7QaiOL8Yjqw1kScHgQGzsXJeyY0N8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782212535; c=relaxed/simple; bh=GA3eOKpoCqLuIqNPyhGE8RvBfQeG+XtuuDwgEsGyDMM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jeug8+LNMq8dQca5UQEXtAJkcHySSELAc5tN71UPMQ5JyIfVjIuDjGjt6OBn15VQYxQq4byikZugjgTfku6Frhr8oCpdg3lTmamrmOD4zb0ZEEoRFNzYl6t0S0jtoQxhqNP3l+wVQ+489INWtgAOztA3JSClYfSq86lDWOxTbMM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=CHN+T5lu; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="CHN+T5lu" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CAF6A1A25; Tue, 23 Jun 2026 04:02:08 -0700 (PDT) Received: from [10.164.148.38] (unknown [10.164.148.38]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 503EC3FA1F; Tue, 23 Jun 2026 04:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1782212533; bh=GA3eOKpoCqLuIqNPyhGE8RvBfQeG+XtuuDwgEsGyDMM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CHN+T5lu9uqaWBlfC9XFYIP9gEtNlbd59Y5tDsxyeLKVy1rwTNvHuq9K/lycDrFMG /eqxhJkf5W/Xu6D5Pff1URRz6EBcV1hauD5rYy6HsUlFaLAxX2pqjusjtxaobEwNKl Fq8fBa4BNccam4GgZEevNwMdTnmYTM2ziuGYs9so= Message-ID: <40576470-e0e0-4e7b-b9bb-be10944f75d4@arm.com> Date: Tue, 23 Jun 2026 16:31:56 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 10/12] mm/rmap: refactor anon folio unmap in try_to_unmap_one To: "David Hildenbrand (Arm)" , akpm@linux-foundation.org, ljs@kernel.org, chrisl@kernel.org, kasong@tencent.com, hughd@google.com, liam@infradead.org Cc: riel@surriel.com, vbabka@kernel.org, harry@kernel.org, jannh@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, qi.zheng@linux.dev, shakeel.butt@linux.dev, baohua@kernel.org, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, shikemeng@huaweicloud.com, nphamcs@gmail.com, bhe@redhat.com, youngjun.park@lge.com, baolin.wang@linux.alibaba.com, pfalcato@suse.de, ryan.roberts@arm.com, anshuman.khandual@arm.com References: <20260526063635.61721-1-dev.jain@arm.com> <20260526063635.61721-11-dev.jain@arm.com> <645a5246-0f9b-4b93-9483-e6bba35f037b@kernel.org> Content-Language: en-US From: Dev Jain In-Reply-To: <645a5246-0f9b-4b93-9483-e6bba35f037b@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16/06/26 7:40 pm, David Hildenbrand (Arm) wrote: > On 5/26/26 08:36, Dev Jain wrote: >> Refactor anonymous folio unmap to ttu_anon_folio. > > Given that the !folio_test_swapbacked() case remains in the caller, should we > make it clearer and call it > > ttu_anon_swapbacked_folio() > > Or alternatively, factor complete anon folio handling out (incl. lazyfree handling)? Hmm I'll see if this can be done. > >> >> No functional change intended. >> >> Signed-off-by: Dev Jain >> --- >> mm/rmap.c | 116 ++++++++++++++++++++++++++++++++---------------------- >> 1 file changed, 68 insertions(+), 48 deletions(-) >> >> diff --git a/mm/rmap.c b/mm/rmap.c >> index c0e385882f562..b1639bad8e27f 100644 >> --- a/mm/rmap.c >> +++ b/mm/rmap.c >> @@ -2136,6 +2136,70 @@ static inline bool ttu_lazyfree_folio(struct vm_area_struct *vma, >> return true; >> } >> >> +static inline void set_swp_pte_at(struct mm_struct *mm, unsigned long address, >> + pte_t *ptep, swp_entry_t entry, pte_t pteval, bool anon_exclusive) >> +{ >> + pte_t swp_pte = swp_entry_to_pte(entry); >> + >> + if (anon_exclusive) >> + swp_pte = pte_swp_mkexclusive(swp_pte); >> + >> + if (likely(pte_present(pteval))) { >> + if (pte_soft_dirty(pteval)) >> + swp_pte = pte_swp_mksoft_dirty(swp_pte); >> + if (pte_uffd_wp(pteval)) >> + swp_pte = pte_swp_mkuffd_wp(swp_pte); >> + } else { >> + /* Device-exclusive entry */ >> + if (pte_swp_soft_dirty(pteval)) >> + swp_pte = pte_swp_mksoft_dirty(swp_pte); >> + if (pte_swp_uffd_wp(pteval)) >> + swp_pte = pte_swp_mkuffd_wp(swp_pte); >> + } >> + >> + set_pte_at(mm, address, ptep, swp_pte); >> +} >> + >> +static inline bool ttu_anon_folio(struct vm_area_struct *vma, struct folio *folio, >> + struct page *subpage, unsigned long address, pte_t *ptep, >> + pte_t pteval) >> +{ >> + bool anon_exclusive = folio_test_anon(folio) && PageAnonExclusive(subpage); > > "subpage" ;) I'll change that. > > Can be const. Okay. > > [...] > >> } else { >> /* >> * This is a locked file-backed folio, > > Happy to see that function shrink a bit ... >