* [PATCH][2.4.26-pre5][x86_64] pci=noapci bogus warning
@ 2004-03-20 23:10 Mikael Pettersson
2004-03-21 0:55 ` Jeff Garzik
2004-03-22 0:38 ` Andi Kleen
0 siblings, 2 replies; 3+ messages in thread
From: Mikael Pettersson @ 2004-03-20 23:10 UTC (permalink / raw)
To: ak; +Cc: linux-kernel
Andi,
2.4.26-pre5 on x86_64 does implement pci=noacpi, but
using the option triggers a scary message from PCI that
the option is unknown. (It's really e820.c and ACPI
that implement it.)
This is highly confusing when once's trying to figure
out which combination of apic/noapic, acpi=, and pci=
leads to a working system :-(
The patch below fixes this by updating pci-pc.c to
handle "pci=noacpi" like i386 does.
[My MSI K8T-NEO-FIS2R needs ACPI for poweroff (since
there's no APM in the x86_64 kernel), and then pci=noacpi
to prevent ACPI from overriding the perfectly good MP
table's data and mess up the timer and the NIC.]
/Mikael
diff -ruN linux-2.4.26-pre5/arch/x86_64/kernel/pci-pc.c linux-2.4.26-pre5.x86_64-pci=noacpi-fix/arch/x86_64/kernel/pci-pc.c
--- linux-2.4.26-pre5/arch/x86_64/kernel/pci-pc.c 2003-11-29 00:28:11.000000000 +0100
+++ linux-2.4.26-pre5.x86_64-pci=noacpi-fix/arch/x86_64/kernel/pci-pc.c 2004-03-20 23:22:27.000000000 +0100
@@ -645,6 +645,9 @@
} else if (!strncmp(str, "lastbus=", 8)) {
pcibios_last_bus = simple_strtol(str+8, NULL, 0);
return NULL;
+ } else if (!strncmp(str, "noacpi", 6)) {
+ acpi_noirq_set();
+ return NULL;
}
return str;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][2.4.26-pre5][x86_64] pci=noapci bogus warning
2004-03-20 23:10 [PATCH][2.4.26-pre5][x86_64] pci=noapci bogus warning Mikael Pettersson
@ 2004-03-21 0:55 ` Jeff Garzik
2004-03-22 0:38 ` Andi Kleen
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2004-03-21 0:55 UTC (permalink / raw)
To: Mikael Pettersson; +Cc: ak, linux-kernel
Mikael Pettersson wrote:
> diff -ruN linux-2.4.26-pre5/arch/x86_64/kernel/pci-pc.c linux-2.4.26-pre5.x86_64-pci=noacpi-fix/arch/x86_64/kernel/pci-pc.c
> --- linux-2.4.26-pre5/arch/x86_64/kernel/pci-pc.c 2003-11-29 00:28:11.000000000 +0100
> +++ linux-2.4.26-pre5.x86_64-pci=noacpi-fix/arch/x86_64/kernel/pci-pc.c 2004-03-20 23:22:27.000000000 +0100
> @@ -645,6 +645,9 @@
> } else if (!strncmp(str, "lastbus=", 8)) {
> pcibios_last_bus = simple_strtol(str+8, NULL, 0);
> return NULL;
> + } else if (!strncmp(str, "noacpi", 6)) {
> + acpi_noirq_set();
> + return NULL;
> }
Seem to me this runs afoul of the frequent "acpi"/"apic" typo...
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][2.4.26-pre5][x86_64] pci=noapci bogus warning
2004-03-20 23:10 [PATCH][2.4.26-pre5][x86_64] pci=noapci bogus warning Mikael Pettersson
2004-03-21 0:55 ` Jeff Garzik
@ 2004-03-22 0:38 ` Andi Kleen
1 sibling, 0 replies; 3+ messages in thread
From: Andi Kleen @ 2004-03-22 0:38 UTC (permalink / raw)
To: Mikael Pettersson; +Cc: linux-kernel
On Sun, 21 Mar 2004 00:10:03 +0100 (MET)
Mikael Pettersson <mikpe@csd.uu.se> wrote:
> 2.4.26-pre5 on x86_64 does implement pci=noacpi, but
> using the option triggers a scary message from PCI that
> the option is unknown. (It's really e820.c and ACPI
> that implement it.)
Applied. Thanks.
-Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-03-22 0:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-20 23:10 [PATCH][2.4.26-pre5][x86_64] pci=noapci bogus warning Mikael Pettersson
2004-03-21 0:55 ` Jeff Garzik
2004-03-22 0:38 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox