From: Eric Valette <eric.valette@free.fr>
To: Zwane Mwaikambo <zwane@linuxpower.ca>
Cc: akpm@osdl.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.5-rc2-mm1 does not boot. 2.6.5-rc1-mm2 + small fix from axboe was fine
Date: Sun, 21 Mar 2004 22:22:41 +0100 [thread overview]
Message-ID: <405E07A1.9000609@free.fr> (raw)
In-Reply-To: <Pine.LNX.4.58.0403211555110.28727@montezuma.fsmlabs.com>
Zwane Mwaikambo wrote:
> How about the following patch?
Part of this does not apply...
> --- linux-2.6.5-rc2-mm1/init/main.c 21 Mar 2004 17:02:18 -0000
> 1.1.1.1
> +++ linux-2.6.5-rc2-mm1/init/main.c 21 Mar 2004 20:54:19 -0000
> @@ -586,8 +586,8 @@ static int free_initmem_on_exec_helper(v
> char c;
>
> sys_close(fd[1]);
> - sys_read(fd[0], &c, 1);
> - free_initmem();
> + if (sys_read(fd[0], &c, 1) > 0)
> + free_initmem();
> return 0;
> }
This part does apply. I made it by hand...
>
> @@ -596,7 +596,7 @@ static void free_initmem_on_exec(void)
> int fd[2];
>
> do_pipe(fd);
> - kernel_thread(free_initmem_on_exec_helper, &fd, SIGCHLD);
> + kernel_thread(free_initmem_on_exec_helper, &fd, SIGCHLD);
Cosmetic change but yes...
>
> sys_dup2(fd[1], 255); /* to get it out of the way */
> sys_close(fd[0]);
> @@ -643,6 +643,7 @@ static int init(void * unused)
> run_init_process("/init");
>
> prepare_namespace();
> + free_initmem();
This is already done (plus a comment....)???
--
__
/ ` Eric Valette
/-- __ o _. 6 rue Paul Le Flem
(___, / (_(_(__ 35740 Pace
Tel: +33 (0)2 99 85 26 76 Fax: +33 (0)2 99 85 26 76
E-mail: eric.valette@free.fr
next prev parent reply other threads:[~2004-03-21 21:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-21 20:24 2.6.5-rc2-mm1 does not boot. 2.6.5-rc1-mm2 + small fix from axboe was fine Eric Valette
2004-03-21 20:51 ` Zwane Mwaikambo
2004-03-21 21:45 ` Eric Valette
2004-03-22 10:16 ` Eric Valette
2004-03-21 20:55 ` Zwane Mwaikambo
2004-03-21 21:22 ` Eric Valette [this message]
2004-03-21 21:48 ` Eric Valette
2004-03-21 22:08 ` Eric Valette
2004-03-21 22:39 ` Eric Valette
2004-03-22 5:49 ` Zwane Mwaikambo
2004-03-22 19:20 ` Luiz Fernando Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=405E07A1.9000609@free.fr \
--to=eric.valette@free.fr \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox