public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Makefile dependancies: scripts depending on configured kernel?
@ 2004-03-21 22:16 Michael Still
  2004-03-22  5:56 ` Sam Ravnborg
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Still @ 2004-03-21 22:16 UTC (permalink / raw)
  To: Linux Kernel Mailing List


Hey,

the top level Makefile specifies that the scripts depend on the kernel 
being configured before the scripts can be built:

scripts: scripts_basic include/config/MARKER
	$(Q)$(MAKE) $(build)=$(@)

I think that this is probably a problem, because it means people can't 
build any of the documentation targets without having configured the kernel.

Do any of the scripts actually depend on a configured kernel to build? 
How can I verify that none of them need a configured kernel? Commenting 
out the dependancy didn't break anything.

Thanks,
Mikal

-- 

Michael Still (mikal@stillhq.com) | "All my life I've had one dream,
http://www.stillhq.com            |  to achieve my many goals"
UTC + 11                          |    -- Homer Simpson

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Makefile dependancies: scripts depending on configured kernel?
  2004-03-21 22:16 Makefile dependancies: scripts depending on configured kernel? Michael Still
@ 2004-03-22  5:56 ` Sam Ravnborg
  2004-03-22  9:14   ` Michael Still
  0 siblings, 1 reply; 3+ messages in thread
From: Sam Ravnborg @ 2004-03-22  5:56 UTC (permalink / raw)
  To: Michael Still; +Cc: Linux Kernel Mailing List

On Mon, Mar 22, 2004 at 09:16:07AM +1100, Michael Still wrote:
> 
> Hey,
> 
> the top level Makefile specifies that the scripts depend on the kernel 
> being configured before the scripts can be built:
> 
> scripts: scripts_basic include/config/MARKER
> 	$(Q)$(MAKE) $(build)=$(@)
> 
> I think that this is probably a problem, because it means people can't 
> build any of the documentation targets without having configured the kernel.

The dependency for docs is (now) wrong.
It should be:
# Documentation targets
# ---------------------------------------------------------------------------
%docs: scripts_basic FORCE
        $(Q)$(MAKE) $(build)=Documentation/DocBook $@

docproc is the only binary used by Documentation/Docbook, and it is already
placed in scripts_basic.

Trivial - so I will include this in some other kbuild patch
I'm preparing.

> Do any of the scripts actually depend on a configured kernel to build? 
Yes, several of the ninaries do so. Among others empty.o.

> How can I verify that none of them need a configured kernel? Commenting 
> out the dependancy didn't break anything.
Test a bit more, and you will see they are indeed needed.
Note, some archs other than i386 have a bit different requirements
because thay do not use an asm-offsett.h file.

	Sam

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Makefile dependancies: scripts depending on configured kernel?
  2004-03-22  5:56 ` Sam Ravnborg
@ 2004-03-22  9:14   ` Michael Still
  0 siblings, 0 replies; 3+ messages in thread
From: Michael Still @ 2004-03-22  9:14 UTC (permalink / raw)
  To: Sam Ravnborg; +Cc: Linux Kernel Mailing List

Sam Ravnborg wrote:

> The dependency for docs is (now) wrong.
> It should be:
> # Documentation targets
> # ---------------------------------------------------------------------------
> %docs: scripts_basic FORCE
>         $(Q)$(MAKE) $(build)=Documentation/DocBook $@
> 
> docproc is the only binary used by Documentation/Docbook, and it is already
> placed in scripts_basic.

True.

> Trivial - so I will include this in some other kbuild patch
> I'm preparing.

Cool, it will be nice to have this working out of the box again.

> Test a bit more, and you will see they are indeed needed.
> Note, some archs other than i386 have a bit different requirements
> because thay do not use an asm-offsett.h file.

Interesting. I built most of the targets and they still worked. I'm 
happy to accept that it's needed though.

Cheers,
Mikal

-- 

Michael Still (mikal@stillhq.com) | "All my life I've had one dream,
http://www.stillhq.com            |  to achieve my many goals"
UTC + 11                          |    -- Homer Simpson

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-03-22  9:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-21 22:16 Makefile dependancies: scripts depending on configured kernel? Michael Still
2004-03-22  5:56 ` Sam Ravnborg
2004-03-22  9:14   ` Michael Still

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox