2.6..5-rc2 "make modules" fails in drivers/scsi/scsi_transport_spi.c

2.6..5-rc2 "make modules" fails in drivers/scsi/scsi_transport_spi.c

[Jim Ruxton]

Hi any thoughts what I can do to fix this? Thanks
A reply to me as well as the list would be appreciated.

LD [M] drivers/scsi/scsi_mod.o
CC [M] drivers/scsi/scsi_transport_spi.o
drivers/scsi/scsi_transport_spi.c: In function `spi_dv_retrain':
drivers/scsi/scsi_transport_spi.c:388: parse error before `;'
drivers/scsi/scsi_transport_spi.c:392: parse error before `;'
drivers/scsi/scsi_transport_spi.c: In function `spi_dv_device_internal':
drivers/scsi/scsi_transport_spi.c:463: parse error before `;'
drivers/scsi/scsi_transport_spi.c:475: parse error before `;'
drivers/scsi/scsi_transport_spi.c:494: parse error before `;'
drivers/scsi/scsi_transport_spi.c: In function `spi_dv_device':
drivers/scsi/scsi_transport_spi.c:539: parse error before `;'
drivers/scsi/scsi_transport_spi.c:543: parse error before `;'
make[2]: *** [drivers/scsi/scsi_transport_spi.o] Error 1
make[1]: *** [drivers/scsi] Error 2
make: *** [drivers] Error 2

[PATCH] Re: 2.6..5-rc2 "make modules" fails in drivers/scsi/scsi_transport_spi.c

[Tony Breeds]

On Wed, Mar 24, 2004 at 10:12:08AM -0500, Jim Ruxton wrote:
> Hi any thoughts what I can do to fix this? Thanks
> A reply to me as well as the list would be appreciated.
> 
> LD [M] drivers/scsi/scsi_mod.o
> CC [M] drivers/scsi/scsi_transport_spi.o
> drivers/scsi/scsi_transport_spi.c: In function `spi_dv_retrain':
> drivers/scsi/scsi_transport_spi.c:388: parse error before `;'
> drivers/scsi/scsi_transport_spi.c:392: parse error before `;'
> drivers/scsi/scsi_transport_spi.c: In function `spi_dv_device_internal':
> drivers/scsi/scsi_transport_spi.c:463: parse error before `;'
> drivers/scsi/scsi_transport_spi.c:475: parse error before `;'
> drivers/scsi/scsi_transport_spi.c:494: parse error before `;'
> drivers/scsi/scsi_transport_spi.c: In function `spi_dv_device':
> drivers/scsi/scsi_transport_spi.c:539: parse error before `;'
> drivers/scsi/scsi_transport_spi.c:543: parse error before `;'
> make[2]: *** [drivers/scsi/scsi_transport_spi.o] Error 1
> make[1]: *** [drivers/scsi] Error 2
> make: *** [drivers] Error 2

I bet you're using an old (gcc-2.95)  Try:

################################################################################
--- 2.6.5-rc2.clean/drivers/scsi/scsi_transport_spi.c	2004-03-30 10:45:44.000000000 +1000
+++ 2.6.5-rc2.scsi/drivers/scsi/scsi_transport_spi.c	2004-03-30 10:51:01.000000000 +1000
@@ -33,7 +33,7 @@
 #include <scsi/scsi_transport.h>
 #include <scsi/scsi_transport_spi.h>
 
-#define SPI_PRINTK(x, l, f, a...)	printk(l "scsi(%d:%d:%d:%d): " f, (x)->host->host_no, (x)->channel, (x)->id, (x)->lun, ##a)
+#define SPI_PRINTK(x, l, f, a...)	printk(l "scsi(%d:%d:%d:%d): " f, (x)->host->host_no, (x)->channel, (x)->id, (x)->lun , ##a)
 
 static void transport_class_release(struct class_device *class_dev);
 
################################################################################

Yours Tony

        linux.conf.au       http://lca2005.linux.org.au/
	Apr 18-23 2005      The Australian Linux Technical Conference!