From: Jeff Garzik <jgarzik@pobox.com>
To: Sergey Vlasov <vsu@altlinux.ru>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [BUG] sata_via broken by recent libata updates
Date: Wed, 24 Mar 2004 16:19:58 -0500 [thread overview]
Message-ID: <4061FB7E.9000609@pobox.com> (raw)
In-Reply-To: <4061CEB1.3080600@pobox.com>
Jeff Garzik wrote:
> Sergey Vlasov wrote:
>
>> Hello!
>>
>> After updating from 2.4.25-libata1 to 2.4.25-libata9 the sata_via
>> driver stopped working. The module loads and even seems to detect
>> the presense of drives, but the SCSI-emulation devices are not
>> registered:
>
> [...]
>
>> Seems that the problem is caused by changes in the device
>> initialization - calling ata_device_add() from svia_init_one() does
>> not work (at least with the 2.4.x SCSI layer). The following patch
>> solves the initialization problem:
>>
>> --- kernel-source-2.4.25/drivers/scsi/sata_via.c.sata_via-init-fix
>> 2004-03-22 14:03:31 +0300
>> +++ kernel-source-2.4.25/drivers/scsi/sata_via.c 2004-03-24
>> 16:27:50 +0300
>> @@ -264,9 +264,7 @@ static int svia_init_one (struct pci_dev
>>
>> pci_set_master(pdev);
>>
>> - /* FIXME: check ata_device_add return value */
>> - ata_device_add(probe_ent);
>> - kfree(probe_ent);
>> + ata_add_to_probe_list(probe_ent);
>>
>> return 0;
>
>
> Ah, indeed. A bug in the 2.4 backport. Seems to be present in sata_sis
> too.
>
> Thanks for spotting, I just checked in the attached patch.
FYI, this fix is in the 2.4.x patch just posted,
http://www.kernel.org/pub/linux/kernel/people/jgarzik/libata/2.4.25-libata12.patch.bz2
prev parent reply other threads:[~2004-03-24 21:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-24 16:33 [BUG] sata_via broken by recent libata updates Sergey Vlasov
2004-03-24 18:08 ` Jeff Garzik
2004-03-24 21:19 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4061FB7E.9000609@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vsu@altlinux.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox